Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/picture/lib/Drupal/picture/Tests/PictureAdminUITest.php

Line 56: Unused local variable $breakpoints

CommentFileSizeAuthor
#1 drupal-core-remove-unused-local-variable-2080589.patch604 bytesmrsinguyen

Comments

mrsinguyen’s picture

mrsinguyen commented
Status: Active » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2080589.patch604 bytes
yesct’s picture

yesct commented

@mrsinguyen I added hints to the meta for reviewers. Would you like to review a few?

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Needs review » Reviewed & tested by the community

Applies, and is correct.

yesct’s picture

yesct commented

@lokapujya

how did you check? Did you apply it, and then use an IDE and ask it to find unused vars in the file?

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented

Good question. I observed that breakpoints is an unused locally declared array and also ran an inspector in my IDE.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.