Part of meta-issue #2002650: [meta] improve maintainability by removing unused local variables

File /core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php

Line 314: Unused local variable $langcode
Line 501: Unused local variable $key

#3 drupal-core-remove-unused-local-variable-2080561-3.patch663 bytesmrsinguyen
PASSED: [[SimpleTest]]: [MySQL] 58,732 pass(es). View
#1 drupal-core-remove-unused-local-variable-2080561.patch1.04 KBmrsinguyen
PASSED: [[SimpleTest]]: [MySQL] 58,815 pass(es). View


mrsinguyen’s picture

Status:Active» Needs review
1.04 KB
PASSED: [[SimpleTest]]: [MySQL] 58,815 pass(es). View
rhm5000’s picture

Status:Needs review» Needs work

Patch no longer applies.

$ git apply --index drupal-core-remove-unused-local-variable-2080561.patch
error: patch failed: core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php:312
error: core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php: patch does not apply
mrsinguyen’s picture

Status:Needs work» Needs review
663 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,732 pass(es). View
rhm5000’s picture

Status:Needs review» Reviewed & tested by the community

Patch applies and removes unused variable $key, $langcode variable no-longer in DbLogTest.php.

alexpott’s picture

Title:Remove Unused local variable $langcode from /core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php» Remove Unused local variable from /core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php
Status:Reviewed & tested by the community» Fixed

Committed ef02f36 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.