Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/locale/lib/Drupal/locale/Tests/LocaleContentTest.php

Line 66: Unused local variable $base_url

CommentFileSizeAuthor
#4 2080527-3-remove-unused-variables.patch9.31 KBchertzog
#2 2080527-remove-unused-variables.patch9.27 KBchertzog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented

Closing the following as duplicates:

#2080513: Remove Unused local variable $config from /core/modules/locale/lib/Drupal/locale/PoDatabaseWriter.php
#2080515: Remove Unused local variable $base_url from /core/modules/locale/lib/Drupal/locale/Tests/LocaleTranslationUiTest.php
#2080517: Remove Unused local variable $config from /core/modules/locale/lib/Drupal/locale/Tests/LocaleImportFunctionalTest.php
#2080519: Remove Unused local variable $config from /core/modules/locale/lib/Drupal/locale/Tests/LocaleUpdateTest.php
#2080521: Remove Unused local variable $translations from /core/modules/locale/lib/Drupal/locale/Tests/LocaleStringTest.php
#2080525: Remove Unused local variable $base_url from /core/modules/locale/lib/Drupal/locale/Tests/LocalePathTest.php

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
Status: Active » Needs review
FileSize
2080527-remove-unused-variables.patch9.27 KB

Status: Needs review » Needs work

The last submitted patch, 2080527-remove-unused-variables.patch, failed testing.

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
Status: Needs work » Needs review
FileSize
2080527-3-remove-unused-variables.patch9.31 KB
areke’s picture

areke CreditAttribution: areke commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

The patch applies cleanly and looks good. Thank you.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.