Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/locale/locale.install

Line 302: Unused local variable $project_id
Line 512: Unused local variable $method_id

CommentFileSizeAuthor
#3 drupal-core-remove-unused-local-variable-2080459-3.patch1.19 KBmrsinguyen
#1 drupal-core-remove-unused-local-variable-2080459.patch1.19 KBmrsinguyen

Comments

mrsinguyen’s picture

mrsinguyen commented
Status: Active » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2080459.patch1.19 KB

Attached patch.

linl’s picture

linl commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2080459-3.patch1.19 KB
mcrittenden’s picture

mcrittenden commented
Issue tags: -Needs reroll

Tags

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Removing tags

johnmcc’s picture

johnmcc commented
Status: Needs review » Reviewed & tested by the community

Applies cleanly and addresses the issue. Looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.