Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/language/language.admin.inc

Line 672: Unused local variable $mappings
Line 900: Unused local variable $entity_types

CommentFileSizeAuthor
#4 drupal-core-remove-unused-local-variable-2080429.patch691 bytesmrsinguyen

Comments

mrsinguyen’s picture

mrsinguyen commented
Status: Active » Reviewed & tested by the community

See applied with lasted 8.x

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Active

No patch uploaded.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Active » Needs work
mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2080429.patch691 bytes

Pull lasted drupal 8.x, the variable $mappings still use. Just see variable $entity_types unused in line 834

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.