Remove Unused local variables from language module

Combining some of the files to trim number of patches.

Closing the following as dupilcates:
#2080431: Remove Unused local variable $request from /core/modules/language/lib/Drupal/language/Tests/LanguageUrlRewritingTest.php
#2080433: Remove Unused local variable $base_url from /core/modules/language/lib/Drupal/language/Tests/LanguageListTest.php
#2080437: Remove Unused local variable $base_url from /core/modules/language/lib/Drupal/language/Tests/LanguageConfigurationTest.php
#2080441: Remove Unused local variable $base_url from language/lib/Drupal/language/Tests/LanguageCustomLanguageConfigurationTest.php

Updating issue title

This needed to be re-rolled, so I re-rolled it; however, I changed one thing. In the first patch, the line
list($language, $path) = language_url_split_prefix($request_path, $languages);
was changed to
list($language, ) = language_url_split_prefix($request_path, $languages);
To me, the change makes the code harder to read and understand, meaning even though the variable is unused, it serves a purpose. Because of this, I left the line as it was.

Patch failed to apply.

3: 2080427-3.patch queued for re-testing.

Let's make sure to confirm that there aren't other unused local variables in the module as well.

Sorry, but I can't apply this patch..

3: 2080427-3.patch queued for re-testing.

I'm setting this to needs work as there 5 more unused variables in the language module.

Unused local variable $base_url  (file .../lib/Drupal/language/Tests/LanguageConfigurationTest.php - [language] line: 37)
Unused local variable $base_url (file .../lib/Drupal/language/Tests/LanguageCustomLanguageConfigurationTest.php - [language] line: 37)
Unused local variable $base_url (file .../lib/Drupal/language/Tests/LanguageListTest.php - [language] line: 37)
Unused local variable $request (file .../lib/Drupal/language/Tests/LanguageUrlRewritingTest.php - [language] line: 62)
Unused local variable $mappings (file .../lib/Drupal/language/Form/NegotiationBrowserForm.php - [language] line: 140)

Comment #10 is unhelpful

The list of unused variables are already removed by 2080427-3.patch

Perhaps someone has already applied his comments.

Except for the the last one in NegotiationBrowserForm.php where the quoted variable IS used at line 143 in a foreach loop

3: 2080427-3.patch queued for re-testing.

This patch doesn't apply. What's exactly is wrong, is a fact, that one of file modified by patch doesn't exist: /core/modules/language/language.negotiation.inc (at least at HEAD).
It was removed at 0b55dcd84190efb23e9db99e9fc135979aeec9bc (#1862202)

Old version of patch modifies not-existing function language_from_language(). This function was replaced by method LanguageNegotiationBrowser::getLangcode(). In this method, issue with unused variables doesn't exist.

Rest of patch (test files) applies cleanly and fixes problem at test files. I will try to reroll patch and remove deprecated parts of it.

Adding this comment on behalf of the toronto group sprint team.

We have reviewed this patch and it applied cleanly but upon review we found there were a few usages of deprecated functions,

Specifically the use of language_list which needs to be replaced by: \Drupal::languageManager()->getLanguages();
and language_load() with \Drupal::languageManager()->getLanguage()

Last update lost my comments.

The last patch failed, attached is an updated patch that just addresses un-used local variables in all the Language Test files (using phpstorm code inspect)

Queue for re-testing

Not sure why this change was included as part of this patch:

-    // Get the count of languages.
+    // Reset all language types

Not sure why this change was included as part of this patch:

-    // Get the count of languages.
+    // Reset all language types

It looked like a comment that had come across as part of a copy paste as I didn't see any logic below that referencing or using a count.

Here at the Austin Sprint, I'm going to be working on this issue.

Just rerolled this patch and will continue to review and work on it.

I reviewed the reroll it looks good.
I added to the patch to remove the other few unused variables in language.
Just needs one last review and this should be done.

Looks good!

+ // Reset all language types
Why was this comment added? Let's take that out, and then I think this is good to go.

Ok removed it.

Committed 43324d1 and pushed to 8.x. Thanks!