Part of meta-issue #2002650: [meta] improve maintainability by removing unused local variables

File /core/tests/Drupal/Tests/Component/PhpStorage/MTimeProtectedFileStorageTest.php

Line 87: Unused local variable $storageFactory

#1 drupal-core-remove-unused-local-variable-2080367.patch714 bytesmrsinguyen
PASSED: [[SimpleTest]]: [MySQL] 58,848 pass(es).
[ View ]


mrsinguyen’s picture

Status:Active» Needs review
new714 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,848 pass(es).
[ View ]
YesCT’s picture

Status:Needs review» Reviewed & tested by the community

this looks good: removes the var. phpstorm agrees it was unused and is ok without it. tests come back green. no extra changes.

still applies.

but will conflict with #1908440: Relax MTimeProtectedFileStorage permissions for DX, drush integration and world domination
[edit: wont conflict anymore, other issue is no longer removing it]

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed dd5b41b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.