Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables
File /core/modules/system/lib/Drupal/system/Tests/Database/SelectComplexTest.php
Line 37: Unused local variable $task_field
Line 62: Unused local variable $task_field
Line 63: Unused local variable $priority_field
Line 74: Unused local variable $last_priority
Line 157: Unused local variable $name_field
Line 158: Unused local variable $age_field
Line 163: Unused local variable $record
Line 175: Unused local variable $task_field
Line 180: Unused local variable $record
Line 272: Unused local variable $task_field
Line 285: Unused local variable $pid_field
Line 295: Unused local variable $pid_field
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-2080317-4-6.txt | 943 bytes | michaelhiiva |
| #6 | 2080317-remove-unused-local-6.patch | 3.94 KB | michaelhiiva |
| #4 | 2080317-remove-unused-local-4.patch | 3.93 KB | michaelhiiva |
Comments
Comment #1
chertzogClosing as duplicate of #2080311: Clean up Drupal\system\Tests\Database\SelectTest.php
Comment #2
angel.hThis issue shouldn't have been closed - see https://drupal.org/node/2080311#comment-7909573.
Comment #3
michaelhiiva commentedComment #4
michaelhiiva commentedComment #6
michaelhiiva commentedComment #7
johnmcc commentedLooks good, applies cleanly, and the relevant tests still pass.
Comment #8
alexpottCommitted 92fdd31 and pushed to 8.x. Thanks!