Remove Unused local variable $has_time from /core/modules/datetime/datetime.module [#2080067]

Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/datetime/datetime.module

Line 816: Unused local variable $has_time
Line 864: Unused local variable $has_time
Line 850: Unused local variable $has_time
Line 857: Unused local variable $has_time
Line 843: Unused local variable $has_time
Line 998: Unused local variable $title
Line 1052: Unused local variable $hour

Comment	File	Size	Author
#6	2080067-remove_unused_variables-6.patch	2.35 KB	netsensei
#6
#6	interdiff.txt	1.01 KB	netsensei
#4	2080067-remove_unused_variables-4.patch	1.01 KB	beowulf1416
#4
#1	2080067-remove_unused_variable-1.patch	1.54 KB	beowulf1416
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

beowulf1416 CreditAttribution: beowulf1416 commented 11 September 2013 at 03:56

Status:

Active

» Needs review

File	Size
2080067-remove_unused_variable-1.patch	1.54 KB

removed unused variable $has_time. I was unable to run DateTimePlus test because I haven't installed the Intl PECL extension

Comment #2

YesCT CreditAttribution: YesCT commented 12 September 2013 at 15:11

@beowulf1416 Thanks for making so many patches. How are you feeling about them?

I added some reviewer notes to the meta. If you review a few of these unused var patches, and have advice to add to the meta, please go ahead and edit that meta issue summary. Anyone can edit it.

If you jump into irc http://drupal.org/irc into #drupal-contribute or the core mentoring office hours https://drupal.org/core-mentoring , we can help match you up with some different issues in some other areas.

Comment #3

CaptainWonky CreditAttribution: CaptainWonky commented 15 September 2013 at 16:13

Patch applies ok.

All instances of $has_time have been removed, so the patch works as far as the issue title is concerned.

However, the issue summary includes two other variables: $title and $hour

$title seems to be an unused local variable.

$hour is used, but I assume it's the statement $hour = 0 which needs to be removed, since $hour is not used afterwards.

Comment #4

beowulf1416 CreditAttribution: beowulf1416 commented 16 September 2013 at 02:09

File	Size
2080067-remove_unused_variables-4.patch	1.01 KB

removing $hour and $title also.
great eyes!

Comment #5

rhm5000 CreditAttribution: rhm5000 commented 21 September 2013 at 05:13

Status:

Needs review

» Needs work

The #4 patch is not quite correct, should include changes made in #1 as the patch has not been reviewed and commited. Changes in #4 otherwise seem fine and patch applies. Changing status to needs work.