Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemGroup.php

Line 101: Unused local variable $id

Combine issues:

- #2080035: Remove Unused local variable $name from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/RearrangeFilter.php
- #2079891: Remove Unused local variable $name from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Rearrange.php
- #2079881: Remove Unused local variable $stack from /core/modules/views_ui/lib/Drupal/views_ui/ViewUI.php

CommentFileSizeAuthor
#21 drupal-core-remove-unused-local-variable-2080047-7.patch2.35 KBalex dicianu
#16 drupal-core-remove-unused-local-variable-2080047-16.patch2.35 KBmrsinguyen
#12 drupal-core-remove-unused-local-variable-2080047-5.patch2.98 KBmrsinguyen
#11 drupal-core-remove-unused-local-variable-2080047-4.patch2.63 KBmrsinguyen
#6 drupal-core-remove-unused-local-variable-2080047-3.patch2.87 KBmrsinguyen
#5 drupal-core-remove-unused-local-variable-2080047-2.patch5.09 KBmrsinguyen
#4 drupal-core-remove-unused-local-variable-1-2080047.patch725 bytesmrsinguyen
#1 drupal-core-remove-unused-local-variable-2080047.patch732 bytesmrsinguyen

Comments

mrsinguyen’s picture

mrsinguyen commented
Status: Active » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2080047.patch732 bytes

Attached patch.

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, drupal-core-remove-unused-local-variable-2080047.patch, failed testing.

mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Needs review
Issue tags: +Novice

#1: drupal-core-remove-unused-local-variable-2080047.patch queued for re-testing.

mrsinguyen’s picture

mrsinguyen commented
StatusFileSize
new drupal-core-remove-unused-local-variable-1-2080047.patch725 bytes

Just removed the unused variable.

mrsinguyen’s picture

mrsinguyen commented
StatusFileSize
new drupal-core-remove-unused-local-variable-2080047-2.patch5.09 KB

Combine issue:

- #2080035: Remove Unused local variable $name from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/RearrangeFilter.php
- #2079891: Remove Unused local variable $name from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Rearrange.php
- #2079881: Remove Unused local variable $stack from /core/modules/views_ui/lib/Drupal/views_ui/ViewUI.php

mrsinguyen’s picture

mrsinguyen commented
StatusFileSize
new drupal-core-remove-unused-local-variable-2080047-3.patch2.87 KB

Above wrong because include SearchAdvancedSearchFormTest.php

mrsinguyen’s picture

mrsinguyen commented
Title: Remove Unused local variable $id from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemGroup.php » Remove Unused local variable from views_ui module
mrsinguyen’s picture

mrsinguyen commented
Issue summary: View changes

Updated

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, drupal-core-remove-unused-local-variable-2080047-3.patch, failed testing.

mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Needs review

#6: drupal-core-remove-unused-local-variable-2080047-3.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice

The last submitted patch, drupal-core-remove-unused-local-variable-2080047-3.patch, failed testing.

mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Needs review
StatusFileSize
new drupal-core-remove-unused-local-variable-2080047-4.patch2.63 KB
mrsinguyen’s picture

mrsinguyen commented
StatusFileSize
new drupal-core-remove-unused-local-variable-2080047-5.patch2.98 KB

Added correct patch.

linl’s picture

linl commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Needs review
Issue tags: -Novice, -Needs reroll

#12: drupal-core-remove-unused-local-variable-2080047-5.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +Needs reroll

The last submitted patch, drupal-core-remove-unused-local-variable-2080047-5.patch, failed testing.

mrsinguyen’s picture

mrsinguyen commented
StatusFileSize
new drupal-core-remove-unused-local-variable-2080047-16.patch2.35 KB
mrsinguyen’s picture

mrsinguyen commented
Status: Needs work » Needs review
mcrittenden’s picture

mcrittenden commented
Issue tags: -Needs reroll

Tags

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Removing tags

linl’s picture

linl commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies, needs another reroll.

alex dicianu’s picture

alex dicianu commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new drupal-core-remove-unused-local-variable-2080047-7.patch2.35 KB

This is my first re-roll attempt ever so please be gentle. Followed the instructions from here: https://drupal.org/patch/reroll

alex dicianu’s picture

alex dicianu commented
Issue summary: View changes

Updated issue summary.

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I checked the three files which are changed here and the proposed removals are fine.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

21: drupal-core-remove-unused-local-variable-2080047-7.patch queued for re-testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

21: drupal-core-remove-unused-local-variable-2080047-7.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.