Strings wont be picked up for translation.

see #2019679: Support for Drupal 8 $this->t()

CommentFileSizeAuthor
#1 drupal-forum-2079477.patch4.32 KBParisLiakos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Active » Needs review
FileSize
drupal-forum-2079477.patch4.32 KB

also fixed the typehint in ForumController

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Thanks I missed that this had gone in. Is there no interface?

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented

well, no..here is the change notice:
https://drupal.org/node/2079611
and the conversation in #2018411: Figure out a nice DX when working with injected translation

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

So we're relying on searching for t()?

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented

yes, strings for localize.d.o will only be picked in t('') or $this->t('') context. anything else wont be parsed

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

In that case

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.