Flag_friend has a dependency on Flag module. Flag module has released a Flag 7.x-3.x; while the Flag_Friend is only compatible with Flag 7.x-2.x ... so the maintainers added a versioned dependency to the Flag_Friend info file.

However, even after rebulding the dependencies, this isn't being picked up.

Digging further, the dependency rebuild isn't processing a number of flag_friend releases ... it processes up to 7.x-1.x-alpha9, but doesn't process 7.x-1.x-alpha10 or 7.x-1.x-alpha11. I'm not sure if this is due to a bug in project_dependency choking on the two-digit suffix, or if the sourcecode cache is frozen.

I could have tried to remove the entire sourcecode cache, but the jenkins script seems to at least attempt to remove the sourcecode directory, and I don't see any errors in the output ... which would indicate that the problem could be in project_dependency itself.

Looking to Randy for possible insight.

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

I don't see the current dependency (dependencies[] = flag (2.x)) listed as an option in https://drupal.org/node/542202.

I suspect you'll want to try something like what's recommended there, dependencies[] = exampleapi (>1.0, <=3.2, !=3.0)

Probably just saying

dependencies[] = flag (2.1)

will be just right. Looks like there won't be any more work done on 7.x-2.x... Currently it's picking up 7.x-3.1 because that's the recommended version.

socketwench’s picture

socketwench commented

I've created a Beta release to see if that works around the issue.

jthorson’s picture

jthorson commented

Dependencies now list flag 7.x-2.1. It would be nice to get this to 7.x-2.x-dev, so that future bug fixes releases on the 7.x-2.x branch don't break things.

I wonder if either of the following might work:
flag (=2.x)
flag (>=2.x, <3.x)

Current dependency calculation for 7.x-1.x-dev:

Array
(
    [1990776] => Array
        (
            [uri] => flag
            [version] => 7.x-2.1
            [tag] => 7.x-2.1
            [dependency_type] => 0
        )

    [1965242] => Array
        (
            [uri] => views
            [version] => 7.x-3.7
            [tag] => 7.x-3.7
            [dependency_type] => 1
        )

    [1738460] => Array
        (
            [uri] => ctools
            [version] => 7.x-1.2
            [tag] => 7.x-1.2
            [dependency_type] => 0
        )
)
rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Fixed

I'm pretty sure that what fixed it was

dependencies[] = flag (2.1)

I don't think =2.x would be right at all; it would have to be =2.x-dev in that case anyway.

But it would work with

dependencies[] = flag (>=2.1, <=3.0)

although surely

dependencies[] = flag (>=2.1, <= 2.99)

jthorson’s picture

jthorson commented

Sure, that should have read

dependencies[] = flag (>=2.x, <3.0)

There shouldn't be anything wrong with the (2.x) ... it is listed in the documentation as valid, though I seem to recall running into an issue before on a similar configuration with another project. In any case, (2.1) alone probably isn't what is wanted, as that's a specific dependency and the first security release that comes along for Flag (resulting in 7.x-2.2) will render this no longer compatible.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

socketwench’s picture

socketwench commented
Issue summary: View changes
Status: Closed (fixed) » Active

Looks like this issue is back after the D.O upgrade to 7.x:

https://qa.drupal.org/pifr/test/674903

Again, the testbot is pulling down the wrong version of Flag -- 3.2 and not the 2.1 specified in Flag Friend's *.info file.

jthorson’s picture

jthorson commented

Confirmed ... and again, even after rebuilding the dependencies, the wrong flag version is still listed.

Looks like we'll need to dig into project_dependency a bit ... I'll try and see if I can get trobey to look into things.

jthorson’s picture

jthorson commented
Status: Active » Postponed

Postponing, pending resolution of https://drupal.org/node/2159429.

jthorson’s picture

jthorson commented
Status: Postponed » Fixed

With #2159429: Check version compatibility now closed, I believe this is now resolved.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.