Part of #2072251: [meta] Modernize forms to use FormBase

Updated: Comment #N


Now that #2059245: Add a FormBase class containing useful methods is in, I was looking at old forms that have empty validateForm() methods, or still use Drupal::service() or t().

Proposed resolution

Convert existing FormInterface forms to extend FormBase

Remaining tasks

User interface changes

API changes

#1 simpletest_forms-2078007-1.patch697 bytesplopesc
PASSED: [[SimpleTest]]: [MySQL] 58,090 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


plopesc’s picture

Status: Active » Needs review
697 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,090 pass(es). View

Simpletest forms included an empty call to validateForm(). Apart form that, it looks good.


aspilicious’s picture

Does it extends formbase?

plopesc’s picture

Yep ;)

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5f9ca4d and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.