Closed (fixed)
Project:
Drupal core
Version:
6.0-rc1
Component:
forum.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Jan 2008 at 21:45 UTC
Updated:
23 Jan 2008 at 21:46 UTC
Jump to comment: Most recent file
Comments
Comment #1
gábor hojtsyThis should use format_plural() as in tracker.pages.inc for example:
format_plural($new, '1 new', '@count new')Comment #2
gábor hojtsyI though I'd look into this and fix quickly, but then realized that the second case might have been a bogus direct copy of the first, as in the second case, we might need to deal with the $topic->new_replies and not the $variables['forums'][$id]->new_topics. I did not have time to test this now tough, so here is the patch for testing.
Comment #3
dvessel commentedPlural? Why? "new" is new... 1 new/2 new/etc..
Or my grasp on the language is poor. ;)
Comment #4
gábor hojtsyTracker module already uses a plural friendly @count new. I am not sure what languages might be affected, Hungarian is not, but meba reported this, and he does the Czech translation. Also, in #2 I noted that there might be a copy-paste bug there, if we look closer, so the wrong count might be displayed. Therefore I would not mark this by design even if there will be no plural use there.
Comment #5
meba commentedCzech:
1 new = 1 nový
2 new = 2 nové
5 new = 5 nových
Comment #6
meba commentedSeems OK for me
Comment #7
meba commentedSetting back status, sorry
Comment #8
dvessel commentedheh, excuse me.
Gábor, your right. The second one would be a bug. This patch is the same, just clears the fuzz.
Comment #9
gábor hojtsyThanks, committed.
Comment #10
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.