Inspired by #2058279: Align mini pager accessibility markup to full pager., currently postponed on changes in #2004872: [meta] Theme system architecture changes and resolution of #939462: Specific preprocess functions for theme hook suggestions are not invoked (we need the ability to have a suggestion-specific preprocess function).

Updated: Comment #3

Problem/Motivation

The default pager and the Views mini pager use an identical Twig template. Let's consolidate them and have the mini pager use a theme suggestion instead.

Proposed resolution

  • Remove views-mini-pager.html.twig, update any calls to '#theme' => 'views_mini_pager' to 'pager__mini_pager' or similar.
  • Use a suggestion-specific preprocess function (template_preprocess_pager__mini_pager()) - postponed on changes in #2004872: [meta] Theme system architecture changes.

Remaining tasks

Create patch

User interface changes

n/a

API changes

Removal of views_mini_pager theme hook.

#2058279: Align mini pager accessibility markup to full pager.
#1912604: Convert theme_views_mini_pager to twig
#1804614: [meta] Consolidate similar twig templates and properly use theme suggestions in core

CommentFileSizeAuthor
#10 views-mini-pager-to-pager-suggestion-2076301-10.patch9.51 KBl0ke
#9 views-mini-pager-to-pager-suggestion-2076301-9.patch6.05 KBl0ke

Comments

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue tags: +theme system cleanup

Missing tag.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue tags: +Template consolidation

And another.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Updating summary as #2058279: Align mini pager accessibility markup to full pager. is in now.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes

Update first line

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes

Updated issue summary, after #2058279: Align mini pager accessibility markup to full pager. was committed.

star-szr’s picture

star-szr
he/him
Primary language English
commented

Great, thanks @mondrake!

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue summary: View changes

Updated issue summary.

mitokens’s picture

mitokens commented
Issue summary: View changes
Parent issue: » #1804614: [meta] Consolidate similar twig templates and properly use theme suggestions in core
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Postponed » Active

Unpostponing!

dawehner’s picture

dawehner
Primary language German
commented

Well, its maybe not that obvious, because for this case we pass ing different data than for the normal case. Is the use of the same base template still semantically the right thing?

l0ke’s picture

l0ke
Primary language English
Location Ukraine
commented
Assigned: Unassigned » l0ke
Issue tags: +dcuacs2015
l0ke’s picture

l0ke
Primary language English
Location Ukraine
commented
Status: Active » Needs review
StatusFileSize
new views-mini-pager-to-pager-suggestion-2076301-9.patch6.05 KB
l0ke’s picture

l0ke
Primary language English
Location Ukraine
commented
StatusFileSize
new views-mini-pager-to-pager-suggestion-2076301-10.patch9.51 KB

Added pager--mini-pager.html.twig

The last submitted patch, 9: views-mini-pager-to-pager-suggestion-2076301-9.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 10: views-mini-pager-to-pager-suggestion-2076301-10.patch, failed testing.

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented

@lokeoke are you working on it? otherwise please change to unassigned.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Assigned: l0ke » Unassigned
andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 8.0.x-dev » 8.1.x-dev

Is there any policy about to remove templates in 8.x?

dawehner’s picture

dawehner
Primary language German
commented

Well, we would certainly need to keep it, but we could add maybe a special template suggestion, so it will fallback to it, but classy will provide a pager__mini_pager template which is exactly the same as the normal pager?

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue tags: +Twig

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Closed (outdated)

Closing this out as an old issue. Think it would also cause several issues in contrib themes.

smustgrave’s picture

smustgrave commented
Issue tags: +Bug Smash Initiative