From field_views_field_default_views_data()

<?php
 
// Override Node to Content.
 
$group_name = ($entity_info['label'] == t('Node')) ? t('Content') : $entity_info['label'];
?>

Similar code in
file_field_views_data_views_data_alter()
image_field_views_data_views_data_alter()
taxonomy_field_views_data_views_data_alter()

Looks like this comes straight from D7, and is not needed anymore since Node's entity type label is 'Content'...

Files: 
CommentFileSizeAuthor
#9 unneeded-dance-around-entity-label-2076141-8.patch4.19 KBlokapujya
PASSED: [[SimpleTest]]: [MySQL] 58,591 pass(es).
[ View ]
#8 unneeded-dance-around-entity-label-2076141-8.patch4.19 KBlokapujya
PASSED: [[SimpleTest]]: [MySQL] 58,881 pass(es).
[ View ]
#5 unneeded-dance-around-entity-label-2076141-4.patch3 KBlokapujya
PASSED: [[SimpleTest]]: [MySQL] 58,490 pass(es).
[ View ]

Comments

yched’s picture

Status:Active» Postponed

Trivial fix, but this is going to conflict with #1497374: Switch from Field-based storage to Entity-based storage, so let's rather get that other one in first :-)

klonos’s picture

Title:Unneded dance around 'Node'/'Content' entity label in views integration code» Unneeded dance around 'Node'/'Content' entity label in views integration code

...typo ;)

yched’s picture

Status:Postponed» Active
Issue tags:+Novice

Un-postponing.

Any takers ? Trivial patch here :-)

lokapujya’s picture

Assigned:Unassigned» lokapujya
lokapujya’s picture

StatusFileSize
new3 KB
PASSED: [[SimpleTest]]: [MySQL] 58,490 pass(es).
[ View ]

No more dancing around this issue.

lokapujya’s picture

Status:Active» Needs review
yched’s picture

Status:Needs review» Needs work

Thanks @lokapujya !
You're just missing image_field_views_data_views_data_alter(), otherwise it's good :-)

lokapujya’s picture

Status:Needs work» Needs review
StatusFileSize
new4.19 KB
PASSED: [[SimpleTest]]: [MySQL] 58,881 pass(es).
[ View ]

Thanks. Updated.

lokapujya’s picture

StatusFileSize
new4.19 KB
PASSED: [[SimpleTest]]: [MySQL] 58,591 pass(es).
[ View ]

Thanks. Updated.

Status:Needs review» Needs work
Issue tags:-Novice

The last submitted patch, unneeded-dance-around-entity-label-2076141-8.patch, failed testing.

swentel’s picture

Status:Needs work» Needs review
Issue tags:+Novice
swentel’s picture

forum.view.inc also contains a 'label' => t('Node'), maybe we should change that to 'Content' in the same run ?

yched’s picture

Status:Needs review» Reviewed & tested by the community

@swentel: Hmm, not sure about that one.
The code that gets removed here took care of moving some strings from 'Node' to 'Content', while the actual strings were already 'Content' anyway.
The current code in forum.view.inc specifically uses 'Node' in HEAD. Agreed that it feels wrong, I wouldn't feel fully comfortable changing it here, that feels like a separate issue.

#8 and #9 have the same patch (double post ?), and #8 is green, so RTBC.

lokapujya’s picture

Yes, it was just an accidental double post.

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

webchick’s picture

Committed and pushed to 8.x. Thanks! :D

Automatically closed -- issue fixed for 2 weeks with no activity.