The Aggregated Fields interface shows only the field title, which can be ambiguous. For example, using https://drupal.org/project/title, provides a "Title" field, with the machine name field_title. The current interface provides no distinction between the two "Title" fields.

I suggest adding the field description or machine name to the Aggregated Fields interface.

Comments

leeomara’s picture

StatusFileSize
new1.01 KB

Simple patch adding the field description to the title attribute of the checkbox text.

drunken monkey’s picture

Title: disambiguate contained fields in "Aggregated Fields" » Add descriptions to field lists for "Aggregated Fields"
Category: bug » feature
Priority: Minor » Normal
Status: Active » Needs review
StatusFileSize
new704 bytes

Great suggestion, thanks! We've luckily already fixed these ambiguities in most other places, but this one still remains, you're right.

Also, I didn't even know HTML was allowed there! Escaping in Drupal really is an inconsistent mess …
But, if it is allowed, we should also escape the field name, shouldn't we? Slightly revised patch attached.

leeomara’s picture

Rather than placing HTML in the label, this alternate approach uses the #description attribute of checkboxes. It certainly makes the list larger, but it has the advantage of being more obvious (no need to hover to see the title).

Status: Needs review » Needs work

The last submitted patch, 2075839-3_aggregate_fields_description.patch, failed testing.

leeomara’s picture

Welp, it works better without the syntax error.

leeomara’s picture

Status: Needs work » Needs review

*sigh*.. I'll get the hang of this soon.

drunken monkey’s picture

Ah, yes, that looks very nice! Code is also fine – we just need to escape the description, too, it seems.

drunken monkey’s picture

Status: Needs review » Fixed

Committed.
Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.