Upgraded from 5.x-2.1 to 5.x.2-2 and lightbox stopped working with Acidfree. I tried a few things like deleting and re-installing, etc.
Re-installed 5.x.2-1 and all is working again.

CommentFileSizeAuthor
#6 lightbox2_207540.patch5.17 KBstella

Comments

stella’s picture

Status: Active » Postponed (maintainer needs more info)

What version of Acidfree are you using? What browser(s) are you using and on what platform(s)?

In what way does lightbox stop working? Does it crash or give any errors? Does the image open on a white page? Or does the lightbox appear but the image never loads? Or does it bring you to the node page when clicked on?

What are your lightbox2 settings? Are you using lightbox2 lite? Is automatic image handling enabled? etc.

Cheers,
Stella

artis’s picture

My installation of Lightbox V2 5.x-2.2 is working with Acidfree 5.x-1.x-dev except for the Galleries option. When I check "Disable Lightbox for Gallery Lists" then nothing changes. If I click on an acidfree album thumbnail it opens the thumbnail in Lightbox2. Any ideas?

BTW.. tested in both Firefox 2 and IE7.

stella’s picture

Category: bug » support
Status: Postponed (maintainer needs more info) » Fixed

That option (disable for gallery lists) only applies to image galleries created by the "image gallery" module. I'll update the help text to make this clearer. You might want to consider the "disable lightbox for these urls" setting for your acidfree galleries.

Cheers,
Stella

artis’s picture

FYI: I made it work by hacking /js/image_nodes.js

Line 18:

if (!settings.disable_for_gallery_lists || (settings.disable_for_gallery_lists && !$(this).parents(".galleries").length)) {

I changed ".galleries" to ".acidfree-folder"

if (!settings.disable_for_gallery_lists || (settings.disable_for_gallery_lists && !$(this).parents(".acidfree-folder").length)) {

Bet it wouldn't be too hard to make a checkbox in the Lightbox settings for Acidfree galleries.

Artis

stella’s picture

Status: Fixed » Active
stella’s picture

StatusFileSize
new5.17 KB

Try the attached patch.

Cheers,
Stella

artis’s picture

Nope. That doesn't work. I was using 5.x-2.2 and the patch won't apply to it. I did download the 5.x-2.x-dev since I saw it has the checkbox, but it doesn't work either. The new "Image trigger size:" option seems to be interfering. If I don't select thumbnail then lightbox doesn't work at all. If I select thumbnail then the Acidfree album opens in lightbox when I click it.

Thanks for the try. I'll go back to using my hack. I'll look back here to see if you have another patch I can try later.

Artis

artis’s picture

Version: 5.x-2.2 » 5.x-2.x-dev

I just tried replacing that same line again on the 5.x-2.x-dev code with my hack above and it works. Go figure. I'll look and see if I can figure out what it wrong with that line and let you know.

Artis

artis’s picture

Still don't know what's wrong with this line 18 of /js/image_node.js:

if ((!settings.disable_for_gallery_lists && !settings.disable_for_acidfree_gallery_lists) || (settings.disable_for_gallery_lists && !$(this).parents(".galleries").length) || (settings.disable_for_acidfree_gallery_lists && !$(this).parents(".acidfree-folder").length)) {

But this works:

               if (!settings.disable_for_acidfree_gallery_lists || (settings.disable_for_acidfree_gallery_lists && !$(this).parents(".acidfree-folder").length)) {
                               if (!settings.disable_for_gallery_lists || (settings.disable_for_gallery_lists && !$(this).parents(".galleries").length)) { 

line 57 add:
}

You also have to uncheck "Disable Lightbox for Gallery Lists".
and check "Disable Lightbox for Acidfree Gallery Lists"

Hope that helps.

Artis

stella’s picture

Status: Active » Needs review

I've just modified the javascript again. Please try out the latest dev version. I've changed the check to be:

if ((!settings.disable_for_gallery_lists && !settings.disable_for_acidfree_gallery_lists) || (!$(this).parents(".galleries").length && !$(this).parents(".acidfree-folder").length && !$(this).parents(".acidfree-list").length) || ($(this).parents(".galleries").length && !settings.disable_for_gallery_lists) || (($(this).parents(".acidfree-folder").length || $(this).parents(".acidfree-list").length) && !settings.disable_for_acidfree_gallery_lists)) {

Cheers,
Stella

stella’s picture

Status: Needs review » Fixed

Released in 5.x-2.3 and 6.x-1.3.

Cheers,
Stella

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.