Updated: Comment #N

Problem/Motivation

We have lost the 'Add new forum' and 'Add new container' local actions from /admin/structure/forum

Proposed resolution

Add them back
Add a test

Remaining tasks

Write patch
Write test

User interface changes

Buttons come back

API changes

None

#1926296: Write tour integration for forum.module

CommentFileSizeAuthor
#3 forum-actions-2073197.fail_.patch810 byteslarowlan
#3 forum-actions-2073197.pass_.patch1.46 KBlarowlan

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Closed (duplicate)

Adding test (as part of tour) and fix in #1926296: Write tour integration for forum.module

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Closed (duplicate) » Active

Things taking longer than planned in #1926296: Write tour integration for forum.module, fixing here instead

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new forum-actions-2073197.pass_.patch1.46 KB
new forum-actions-2073197.fail_.patch810 bytes

Fail/Pass

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Why not just convert them to the new format and move them to a forum.local_actions.yml?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

We can't do that until #1974210: Convert admin/structure/forum to a Controller is in, admin/structure/forum is still using hook_menu page callbacks and is blocked on #1974492: Convert taxonomy_overview_terms to a Form Controller

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +blocker

Blocks #1926296: Write tour integration for forum.module

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Fair enough! See you over in #1974210: Convert admin/structure/forum to a Controller

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 95a13fe and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.