From http://bootply.com/bootstrap-3-migration-guide

  • remove .navbar-inner
  • replace .brand with .navbar-brand
  • wrap .navbar-brand and .navbar-toggle inside .navbar-header
  • add .navbar-nav to .nav

From http://blog.getbootstrap.com/2013/08/19/bootstrap-3-released/

Navbars now require a .navbar-default for the standard version.

And from bootstrap new documentation http://getbootstrap.com/components/#navbar

Files: 
CommentFileSizeAuthor
#4 bootstrap-navbar-migration-2072269-4.patch3.5 KBel7cosmos
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View
#1 bootstrap-navbar-migration-2072269-1.patch3.66 KBel7cosmos
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

Comments

el7cosmos’s picture

FileSize
3.66 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View
el7cosmos’s picture

Status: Active » Needs review
markcarver’s picture

Status: Needs review » Needs work
+++ b/templates/page.tpl.php
@@ -1,12 +1,13 @@
-      <!-- .btn-navbar is used as the toggle for collapsed navbar content -->
...
+    <!-- Brand and toggle get grouped for better mobile display -->

@@ -15,27 +16,28 @@
+      <!-- Collect the nav links, forms, and other content for toggling -->
...
+      </div><!-- /.navbar-collapse -->

I know we have a few HTML comments, but I'd rather be consistent and just take these out all together.

el7cosmos’s picture

Status: Needs work » Needs review
FileSize
3.5 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View
markcarver’s picture

Status: Needs review » Fixed

Thanks! Committed b63ca8b.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

markcarver’s picture

Version: 7.x-3.x-dev » 7.x-3.0-beta1