Replace less files in bootstrap_subtheme with bootstrap 3

CommentFileSizeAuthor
#6 upgrade-subtheme-less-2071975.patch457 byteskslonka
#2 bootstrap-upgrade-subtheme-less-2071975-2.patch31.43 KBel7cosmos
#1 bootstrap-upgrade-subtheme-less-2071975-1.patch29.14 KBel7cosmos

Comments

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
commented
Status: Active » Needs review
StatusFileSize
new bootstrap-upgrade-subtheme-less-2071975-1.patch29.14 KB

Only replace less file, still need work with override.less

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
commented
StatusFileSize
new bootstrap-upgrade-subtheme-less-2071975-2.patch31.43 KB

Sorry, the previous is version 3.0.0-rc1

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed

Thanks @el7cosmos! Committed 488300a.

Given that this seems like a relatively straight forward replacement (and a rather large patch), I've gone ahead and committed this. Any regressions found should be opened in a new issue (including fixing the overrides.less file).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kslonka’s picture

kslonka commented 
+++ b/bootstrap_subtheme/less/variables.less
@@ -6,131 +6,177 @@
+@icon-font-path:          "../fonts/";

This should be "../bootstrap/fonts" (since our css is in theme/css, and bootstrap library is in theme/bootstrap)

kslonka’s picture

kslonka commented
StatusFileSize
new upgrade-subtheme-less-2071975.patch457 bytes

@up patch

markhalliwell’s picture

markhalliwell
Primary language English
commented

Thanks @kslonka!

Committed 4b97a6e to 7.x-3.x.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 7.x-3.x-dev » 7.x-3.0-beta1