Updated: Comment #0

Problem/Motivation

ForumFormController is unlike all other FormInterface in that it gets the request directly from the container in createInstance(), instead of buildForm().

Furthermore, #2059245: Add a FormBase class containing useful methods is removing the buildForm() approach used by every other form, and introduces a getRequest() method.

Proposed resolution

Use getRequest() in ForumFormController

Remaining tasks

User interface changes

N/A

API changes

Constructor change.

CommentFileSizeAuthor
#1 forum-2071429-1.patch2.3 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs work
FileSize
forum-2071429-1.patch2.3 KB

Will mark needs review once the FormBase goes in.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review

That went in.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

Yep

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.