The page title test class name was renamed in #2032535: Resolve 'title' using the route and render array but somehow the filename change didn't made it to git.

CommentFileSizeAuthor
#6 interdiff.txt708 bytesdawehner
#6 title-2069191-6.patch1.04 KBdawehner
#3 fix_test_filename-do-not-test.txt353 bytesaspilicious
fix_test_filename.patch10.01 KBaspilicious

Comments

aspilicious’s picture

aspilicious commented
Status: Active » Needs review

no idea why git rename didn't kicked in

dawehner’s picture

dawehner
Primary language German
commented

If you would have made it with git diff -M review would be trivial ...

aspilicious’s picture

aspilicious commented
StatusFileSize
new fix_test_filename-do-not-test.txt353 bytes

diff -M output

Status: Needs review » Needs work

The last submitted patch, fix_test_filename.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Priority: Major » Critical

Am I the only one that gets fatal errors due to this on the test overview page (Cannot redeclare class Drupal\system\Tests\System\PageTitleTest)? If not, then this is pretty critical ;)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new title-2069191-6.patch1.04 KB
new interdiff.txt708 bytes

That is kind of embarrassing to be honest.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. We still have that issue that's supposed to ensure that we don't end up with incorrectly test classes. Shows again that we need it :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Heh, I guess it's not possible to write tests to check if we've named a file incorrectly, so.. :P

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.