Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of #2068325: [META] Convert entity SQL queries to the Entity Query API. See the parent issue for details.
Comment | File | Size | Author |
---|---|---|---|
#10 | 2068337-10-taxonomy-entiry_query_api.patch | 11.48 KB | pfrenssen |
#10 | interdiff.txt | 1.57 KB | pfrenssen |
#9 | remove-taxonomy-data-query.patch | 11.47 KB | marcingy |
#9 | interdiff.txt | 2.02 KB | marcingy |
#3 | remove-taxonomy-data-query.patch | 11.25 KB | marcingy |
Comments
Comment #1
plachComment #2
marcingy CreditAttribution: marcingy commentedComment #3
marcingy CreditAttribution: marcingy commentedFirst stab, I can't get tests to run locally on my windows box without timing out.
Also a lot of the queries against taxonomy_term_data are not efqable so this patch also extends interfaces. Also doesn't touch anything in views yet.
Comment #5
marcingy CreditAttribution: marcingy commented#3: remove-taxonomy-data-query.patch queued for re-testing.
Comment #6
twistor CreditAttribution: twistor commented*int
$vid is a string.
Can we wrap these?
Comment #7
marcingy CreditAttribution: marcingy commented1 & 2 yes I'll do point 3 to be honest is more readable as is in my opinion.
Comment #8
twistor CreditAttribution: twistor commentedWorks for me.
Comment #9
marcingy CreditAttribution: marcingy commentedOk docs fixed.
Comment #10
pfrenssenLooks good to me, only found some tiny nitpicks with namespace ordering (my favourite pet peeve :), and capitalization of the word "ID" in the documentation. AFAIAC this is RTBC.
Comment #11
slashrsm CreditAttribution: slashrsm commentedLooks good to me.
Comment #12
Xano#10: 2068337-10-taxonomy-entiry_query_api.patch queued for re-testing.
Comment #13
catchCommitted/pushed to 8.x, thanks!
Comment #14
plach