Splitting off from #1560012: Port per-user issue notification email functionality to D7 ...

There are a few TODO comments in the code about edge cases regarding comment IDs. In theory, you could programmatically edit an issue multiple times in the same page load, which should generate separate notifications. Mostly the code is now written to handle this, but there are a couple places where we're not as careful as we could be. Pretty minor, since it works great in the normal cases, but I wanted to open an issue so this doesn't get lost.

Comments

drumm’s picture

Issue tags: -drupal.org D7 +Drupal.org 7.1

Since this is theoretical, it is not a launch blocker.

drumm’s picture

Issue summary: View changes

I could see this being triggered by queued issue notifications.

gease’s picture

Assigned: Unassigned » gease
tvn’s picture

Issue tags: +dcdn-sprint
gease’s picture

Status: Active » Needs review
StatusFileSize
new1.61 KB
drumm’s picture

Status: Needs review » Needs work

Looks like a good start. $cid is removed, but is used in the next line:

        $message['headers']['Message-Id'] = "<type=project&nid=$issue->nid&cid=$cid&host=@$domain>";
marvil07’s picture

Status: Needs work » Needs review
StatusFileSize
new2.29 KB
new1.49 KB

This should fix the problem.

  • Commit 9a6f615 on 7.x-2.x authored by gease, committed by drumm:
    Issue #2067651 by gease, marvil07 | dww: Fix edge cases regarding...
drumm’s picture

Status: Needs review » Fixed

Yep, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.