It does not seem to be used anywhere, and I'm not sure why we should provide this.

CommentFileSizeAuthor
#7 remove-xml-apis-2067517-7.patch5.43 KBdevin carlson
#6 remove-xml-apis-2067517-6.patch6.02 KBaaron
#5 remove-xml-apis-2067517-5.patch3.12 KBaaron
#3 remove-xml-apis-2067517-3.patch6 KBdevin carlson

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

These are the only references I can find, none of which actually *use* those functions:
http://drupalcode.org/project/media_youtube.git?a=search&h=refs%2Fheads%...
http://drupalcode.org/project/media_vimeo.git?a=search&h=refs%2Fheads%2F...

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Looks like media_youtube does in fact use this function. :/

devin carlson’s picture

devin carlson commented
Status: Active » Needs review
StatusFileSize
new remove-xml-apis-2067517-3.patch6 KB

Since Media: YouTube is the only module using the XML media cache, and the cache only works with XML, I think that the XML APIs should be removed from Media. I'd also be happy to port all of the XML-related code over to Media: YouTube.

Attached is a patch to remove the XML APIs and drop the cache tables.

devin carlson’s picture

devin carlson commented

After doing some searching it looks like Media: YouTube is the only contrib module which is using the XML APIs and, even then, it is only calling media_retrieve_xml() once. The function is mentioned in a few different provider modules (YouTube, Vimeo) but only in comments which suggest that the function does not currently meet their needs but should be used in the future if it is even "improved".

I opened an issue against Media: YouTube to do its own XML processing (#2068017: Use own XML functions to allow XML APIs to be removed from Media) so it should be okay to remove the XML APIs from Media now.

aaron’s picture

aaron commented
StatusFileSize
new remove-xml-apis-2067517-5.patch3.12 KB

Here is a reroll chasing HEAD

aaron’s picture

aaron commented
StatusFileSize
new remove-xml-apis-2067517-6.patch6.02 KB

Oops, here is the real patch.

devin carlson’s picture

devin carlson commented
StatusFileSize
new remove-xml-apis-2067517-7.patch5.43 KB

An updated patch to accommodate the latest changes.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Tested the updated #7 and didn't run into any problems. I'll make corresponding commit to Media: YouTube.

Committed to Media 7.x-2.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

FYI, as it turned out Media:Flickr used it too: #2089665: Media v2 removed XML APIs, update module

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

BTW the following comment needs to be updated to the Drupal coding standards:

    //if request wasn't successful, create object for return to avoid errors

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.