Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It does not seem to be used anywhere, and I'm not sure why we should provide this.
Comment | File | Size | Author |
---|---|---|---|
#7 | remove-xml-apis-2067517-7.patch | 5.43 KB | Devin Carlson |
#6 | remove-xml-apis-2067517-6.patch | 6.02 KB | aaron |
#5 | remove-xml-apis-2067517-5.patch | 3.12 KB | aaron |
#3 | remove-xml-apis-2067517-3.patch | 6 KB | Devin Carlson |
Comments
Comment #1
Dave ReidThese are the only references I can find, none of which actually *use* those functions:
http://drupalcode.org/project/media_youtube.git?a=search&h=refs%2Fheads%...
http://drupalcode.org/project/media_vimeo.git?a=search&h=refs%2Fheads%2F...
Comment #2
Dave ReidLooks like media_youtube does in fact use this function. :/
Comment #3
Devin Carlson CreditAttribution: Devin Carlson commentedSince Media: YouTube is the only module using the XML media cache, and the cache only works with XML, I think that the XML APIs should be removed from Media. I'd also be happy to port all of the XML-related code over to Media: YouTube.
Attached is a patch to remove the XML APIs and drop the cache tables.
Comment #4
Devin Carlson CreditAttribution: Devin Carlson commentedAfter doing some searching it looks like Media: YouTube is the only contrib module which is using the XML APIs and, even then, it is only calling
media_retrieve_xml()
once. The function is mentioned in a few different provider modules (YouTube, Vimeo) but only in comments which suggest that the function does not currently meet their needs but should be used in the future if it is even "improved".I opened an issue against Media: YouTube to do its own XML processing (#2068017: Use own XML functions to allow XML APIs to be removed from Media) so it should be okay to remove the XML APIs from Media now.
Comment #5
aaron CreditAttribution: aaron commentedHere is a reroll chasing HEAD
Comment #6
aaron CreditAttribution: aaron commentedOops, here is the real patch.
Comment #7
Devin Carlson CreditAttribution: Devin Carlson commentedAn updated patch to accommodate the latest changes.
Comment #8
Devin Carlson CreditAttribution: Devin Carlson commentedTested the updated #7 and didn't run into any problems. I'll make corresponding commit to Media: YouTube.
Committed to Media 7.x-2.x.
Comment #9
DamienMcKennaFYI, as it turned out Media:Flickr used it too: #2089665: Media v2 removed XML APIs, update module
Comment #10
DamienMcKennaBTW the following comment needs to be updated to the Drupal coding standards: