Convert system.module's test's database_test.module's JSON functions to a new-style controller.

+++ b/core/modules/system/tests/modules/database_test/lib/Drupal/database_test/Controller/DatabaseTestJsonController.php
@@ -0,0 +1,149 @@
+class DatabaseTestJsonController {
...
+    $table_name = db_query_temporary('SELECT age FROM {test}', array());
...
+      'row_count' => db_select($table_name)->countQuery()->execute()->fetchField(),
...
+    $query = db_select('test', 't');
...
+    $query = db_select('test_task', 't');
...
+    $query = db_select('test_task', 't');
...
+    $query = db_select('test_task', 't');
+    $query

All this db_select calls could be replaced directly by an injected db connection, so for example extending ControllerBase would just work.

+++ b/core/modules/system/tests/modules/database_test/lib/Drupal/database_test/Controller/DatabaseTestJsonController.php
@@ -0,0 +1,149 @@
+class DatabaseTestJsonController {
...
+    $table_name = db_query_temporary('SELECT age FROM {test}', array());
...
+      'row_count' => db_select($table_name)->countQuery()->execute()->fetchField(),
...
+    $query = db_select('test', 't');
...
+    $query = db_select('test_task', 't');
...
+    $query = db_select('test_task', 't');
...
+    $query = db_select('test_task', 't');
+    $query

All this db_select calls could be replaced directly by an injected db connection, so for example extending ControllerBase would just work.

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

Unassigned, Couldn't spare enough time to look into it.

There has been some changes to the core and some of the changes from the earlier patches have been already committed(eg: removal of hook_menu).
Re-rolling the patch against latest head based on #5-a.patch.
comments from #6/#7 are not considered yet in the current patch.
The patch passed the tests when run locally.

11: system-module.2066557-11-a.patch queued for re-testing.

+++ b/core/modules/system/tests/modules/database_test/database_test.routing.yml
--- /dev/null
+++ b/core/modules/system/tests/modules/database_test/lib/Drupal/database_test/Controller/DatabaseTestJsonController.php

The reason it did conflict is that the other class moved to src/, and this has not yet been updated for that.

Last patch just moves functions to Drupal\database_test\Controller\DatabaseTestController

Thanks, @valthebald!

Just some coding standards stuff:

1. +++ b/core/modules/system/tests/modules/database_test/src/Controller/DatabaseTestController.php
   @@ -6,6 +6,7 @@
    namespace Drupal\database_test\Controller;
   +use Symfony\Component\HttpFoundation\JsonResponse;
   

   Needs a blank line between namespace and use.

2. +++ b/core/modules/system/tests/modules/database_test/src/Controller/DatabaseTestController.php
   @@ -13,38 +14,136 @@
   +   * @return JsonResponse
       */
      public function dbQueryTemporary() {
   

   All of these should be fully qualified like: @return \Symfony\Component\HttpFoundation\JsonResponse

Here we go

Super awesome. :-)

Committed ed7f9d9 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

diff --git a/core/modules/system/tests/modules/database_test/src/Controller/DatabaseTestController.php b/core/modules/system/tests/modules/database_test/src/Controller/DatabaseTestController.php
index 9805fb6..83ed8ad 100644
--- a/core/modules/system/tests/modules/database_test/src/Controller/DatabaseTestController.php
+++ b/core/modules/system/tests/modules/database_test/src/Controller/DatabaseTestController.php
@@ -21,7 +21,7 @@ class DatabaseTestController {
    * separate menu callback request; After this request is done, the temporary
    * table should automatically dropped.
    *
-   * @return Symfony\Component\HttpFoundation\JsonResponse
+   * @return \Symfony\Component\HttpFoundation\JsonResponse
    */
   public function dbQueryTemporary() {
     $table_name = db_query_temporary('SELECT age FROM {test}', array());
@@ -37,7 +37,7 @@ public function dbQueryTemporary() {
    * This function does care about the page GET parameter, as set by the
    * simpletest HTTP call.
    *
-   * @return Symfony\Component\HttpFoundation\JsonResponse
+   * @return \Symfony\Component\HttpFoundation\JsonResponse
    */
   public function pagerQueryEven($limit) {
     $query = db_select('test', 't');
@@ -63,7 +63,7 @@ public function pagerQueryEven($limit) {
    * This function does care about the page GET parameter, as set by the
    * simpletest HTTP call.
    *
-   * @return Symfony\Component\HttpFoundation\JsonResponse
+   * @return \Symfony\Component\HttpFoundation\JsonResponse
    */
   public function pagerQueryOdd($limit) {
     $query = db_select('test_task', 't');
@@ -89,7 +89,7 @@ public function pagerQueryOdd($limit) {
    * This function does care about the page GET parameter, as set by the
    * simpletest HTTP call.
    *
-   * @return Symfony\Component\HttpFoundation\JsonResponse
+   * @return \Symfony\Component\HttpFoundation\JsonResponse
    */
   public function testTablesort() {
     $header = array(
@@ -121,7 +121,7 @@ public function testTablesort() {
    * This function does care about the page GET parameter, as set by the
    * simpletest HTTP call.
    *
-   * @return Symfony\Component\HttpFoundation\JsonResponse
+   * @return \Symfony\Component\HttpFoundation\JsonResponse
    */
   public function testTablesortFirst() {
     $header = array(

Need to have a leading slash - fixed on commit.