It makes sense to add mp3 mov mp4 m4a m4v mpeg avi ogg oga ogv to our default extensions from Media module (excluding wmv and ico, since I'm not sure how much people actually upload those), and just get rid of the Media module setting.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | file_entity-add-more-file-extensions-2066467-6.patch | 2.05 KB | devin carlson |
| #4 | file_entity-add-more-file-extensions-2066467-4.patch | 2.12 KB | saltednut |
Comments
Comment #1
dave reidPossibly we should add things we added support for in file_entity_file_mimetype_mapping_alter()
Comment #2
saltednutOn it.
Comment #3
dave reidLet's add: mp3 mov mp4 m4a m4v mpeg avi ogg oga ogv weba webp webm
Comment #4
saltednutIt looks like all but the weba, webm and webp mimetypes (of what is mentioned in #3) are now in core, so I was able to prune
file_entity_file_mimetype_mapping_alter()fairly extensively.The defaults for
file_entity_default_allowed_extensionswere a bit hard to read so I broke them out into a variable and also added mp3 mov mp4 m4a m4v mpeg avi ogg oga ogv weba webp webm to the delimiter-separated values.Comment #6
devin carlson commented#1443070: Add support for popular e-book formats, Google web formats, mkv and mka in file_default_mimetype_mapping() hasn't been committed yet, so we'll need to keep them around for a while yet. Otherwise the patch looks great.
Comment #7
devin carlson commentedCommitted #6 to File entity 7.x-2.x.