It makes sense to add mp3 mov mp4 m4a m4v mpeg avi ogg oga ogv to our default extensions from Media module (excluding wmv and ico, since I'm not sure how much people actually upload those), and just get rid of the Media module setting.

Comments

dave reid’s picture

Possibly we should add things we added support for in file_entity_file_mimetype_mapping_alter()

saltednut’s picture

Assigned: dave reid » saltednut

On it.

dave reid’s picture

Let's add: mp3 mov mp4 m4a m4v mpeg avi ogg oga ogv weba webp webm

saltednut’s picture

Assigned: saltednut » Unassigned
Status: Active » Needs review
StatusFileSize
new2.12 KB

It looks like all but the weba, webm and webp mimetypes (of what is mentioned in #3) are now in core, so I was able to prune file_entity_file_mimetype_mapping_alter() fairly extensively.

The defaults for file_entity_default_allowed_extensions were a bit hard to read so I broke them out into a variable and also added mp3 mov mp4 m4a m4v mpeg avi ogg oga ogv weba webp webm to the delimiter-separated values.

Status: Needs review » Needs work

The last submitted patch, file_entity-add-more-file-extensions-2066467-4.patch, failed testing.

devin carlson’s picture

Status: Needs work » Needs review
StatusFileSize
new2.05 KB

#1443070: Add support for popular e-book formats, Google web formats, mkv and mka in file_default_mimetype_mapping() hasn't been committed yet, so we'll need to keep them around for a while yet. Otherwise the patch looks great.

devin carlson’s picture

Status: Needs review » Fixed

Committed #6 to File entity 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.