Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is part of #1775842: [meta] Convert all variables to state and/or config systems
Instructions are at https://drupal.org/node/1667896
Comment | File | Size | Author |
---|---|---|---|
#7 | 2066145-convert-node_admin_theme-7.patch | 7.45 KB | mtift |
#7 | interdiff.txt | 793 bytes | mtift |
#4 | 2066145-convert-node_admin_theme-4.patch | 7.51 KB | mtift |
#4 | interdiff.txt | 311 bytes | mtift |
#3 | 2066145-convert-node_admin_theme-3.patch | 7.5 KB | mtift |
Comments
Comment #1
mtiftComment #2
mtiftPatch is attached. In cases where we are currently using TRUE (booleans), I converted them to '1'.
Comment #3
mtiftThe previous patch was wrong on multiple levels, so please ignore it.
Changing node_admin_them to admin_theme could potentially cause confusion with the admin_theme in the system module (especially in ThemeTest.php). I discussed this with @msonnabaum, who suggested use_admin_theme_for_editing_nodes, which seemed more descriptive, but would more accurately need to be named use_admin_theme_for_editing_or_creating_nodes. That seemed too long. @effulgentsia and I thought use_admin_theme would be sufficiently descriptive so that is what I used.
Comment #4
mtiftUpdated patch to make config in node.settings.yml alphabetical.
Comment #5
aspilicious CreditAttribution: aspilicious commentedActually this looks ok :).
Comment #6
alexpottIt seems like we're changing the default behaviour here. When it was a variable the default was false and now it true.
There's no need for this line. Default config is automatically removed on uninstall. And delete() does not clear a single key anyway :)
Comment #7
mtiftUpdated patch attached
Comment #8
aspilicious CreditAttribution: aspilicious commentedBack to rtbc unless I'm missing something again?
Comment #9
catchCommitted/pushed to 8.x, thanks!
Comment #10.0
(not verified) CreditAttribution: commentedUpdated issue summary.