Files: 
CommentFileSizeAuthor
#5 block-2065721-5.patch26.19 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,237 pass(es). View
#4 block-2065721-3.patch26.05 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 57,973 pass(es). View
#4 interdiff.txt5.83 KBtim.plunkett
#1 block-2065721-1.patch20.22 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 56,131 pass(es), 25 fail(s), and 36 exception(s). View

Comments

tim.plunkett’s picture

FileSize
20.22 KB
FAILED: [[SimpleTest]]: [MySQL] 56,131 pass(es), 25 fail(s), and 36 exception(s). View

Here's a start

tim.plunkett’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, block-2065721-1.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
5.83 KB
26.05 KB
PASSED: [[SimpleTest]]: [MySQL] 57,973 pass(es). View

Duh, I only did the ones that directly extended BlockBase, missed the sub-sub-classes.

tim.plunkett’s picture

FileSize
26.19 KB
PASSED: [[SimpleTest]]: [MySQL] 58,237 pass(es). View

Rerolled.

Status: Needs review » Needs work
Issue tags: -DX (Developer Experience), -Plugin system, -Annotation

The last submitted patch, block-2065721-5.patch, failed testing.

Berdir’s picture

Status: Needs work » Needs review
Issue tags: +DX (Developer Experience), +Plugin system, +Annotation

#5: block-2065721-5.patch queued for re-testing.

benjy’s picture

Status: Needs review » Reviewed & tested by the community

OK I tested this, all works good.

I was a little confused at first where the module key had gone but I see it added in processDefinition(). Out of interest, are the array keys that are always available in $definition documented anyway?

tim.plunkett’s picture

Well 'module' is a deprecated key anyway, we need to remove that in favor of 'provider', which is on every plugin ever and is never double documented in an annotation.

alexpott’s picture

Title: Add a dedicated @Block plugin annotation » Change notice: Add a dedicated @Block plugin annotation
Priority: Normal » Critical
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed 0489b63 and pushed to 8.x. Thanks!

Need to update https://drupal.org/node/1880620

longwave’s picture

Status: Active » Needs review
Berdir’s picture

Title: Change notice: Add a dedicated @Block plugin annotation » Add a dedicated @Block plugin annotation
Priority: Critical » Normal
Status: Needs review » Fixed
Issue tags: -Needs change record

Looks ok to me.

Automatically closed -- issue fixed for 2 weeks with no activity.