Closed (fixed)
Project:
Imagecache Token
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Aug 2013 at 17:03 UTC
Updated:
18 Jul 2015 at 13:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jpstrikesback commentedHere's a patch.
Comment #2
cmonnow commentedAlthough I haven't used this module just yet your changes make sense and would affect some of the other issued patches (e.g. https://drupal.org/node/1600266).
Comment #3
srobert72 commented#1600266: no more uri property returned has been commited and fixed.
So now patch proposed in #2064357-1: Token passed to image_style_url should be the style token only should be :
- $output[] = !empty($uri) ? image_style_url($token, $uri) : '';
+ $output[] = !empty($uri) ? image_style_url($type, $uri) : '';
Comment #4
deanflory commentedWhen applying the #1 patch with the changes suggested in #3, I get a FAIL:
Hunk #1 FAILED at 94.
Resulting edited patch:
2064357-pass-style-token-only.patch (edited with #3 changes)
Maybe I did something wrong but it seems like a reroll is needed.
Comment #5
damienmckennaRerolled.
Comment #7
damienmckennaCommitted.