what am i missing? i created a context with custom image formatter but the video is always the same width, should this be working?

CommentFileSizeAuthor
#1 youtube-dimension-player.patch2.09 KBraphael apard

Comments

raphael apard’s picture

StatusFileSize
new2.09 KB

Same problem. Here a quick patch adding width / height per context settings. I'm not sure this is the right way to do this but it's working for me.

discipolo’s picture

Version: 7.x-1.1 » 7.x-1.x-dev
Category: support » feature
Status: Active » Needs review

thanks so much! i thought i was doing something wrong.
patch applies and does as advertised. changing this to feature request since i am not sure whether it qualifies as bug.

jcisio’s picture

Title: i cannot change embedded youtube video width » Add width/height settings per context
Status: Needs review » Needs work

It was discussed briefly in the past but has not been decided. The idea is to have a width/height setting in each context. It usually makes sense, unless it comes to responsive design. But in the latter case, it can use "auto" dimensions.

If you think it is good, then let's implement it. We needs width/height setting (beside transcoder, player) in each context and providers would use that to render.

discipolo’s picture

this patch implements width and height as player settings, not as seperate form fields which i like. i have yet to test if it works with something other than youtube videos

discipolo’s picture

would be great of course if this setting were exportable (features currently allows exporting contexts but doesnt create them when enabling it on a fresh site)

jcisio’s picture

If it is a context setting, it will automatically exportable.

discipolo’s picture

indeed, export works nicely

gnucifer’s picture

I have run in to the same issue but with another third video provider integration I am working on. To implement a "provider_scald_player" works, but breaks the scald abstraction that all videos are just "videos". If you were to use a vimeo video in a youtube player that would not work, so as soon as you need to set height, with, autoplay and other settings for a context you basically lock in to one provider. How would the "scald" way of solving this be?

gnucifer’s picture

(On way would I guess be to have a generic player, with settings that all video providers should be able to implement, but that would restrict all settings to the least common denominator, and generally be a pretty non elegant solution.)

scotwith1t’s picture

It does work, but I wonder about the implementation as @gnucifer does. I suppose you could create a separate context for youtube v. other videos and switch it out in ckeditor with a right-click. If there were an official implementation of this in the module in the near future, that would be awesome. Thanks again for an awesome module and looking forward to implementing on our big project! Thanks for the support.

scotwith1t’s picture

To take the concern a bit further, it's going to be confusing to our content editors to select, say "Full Width" context and they're trying to render an uploaded video from the server, not youtube, so I guess the way around this for now is to either a) separate out youtube as a different atom type with its own set of contexts or b) add contexts that are specific for youtube and default sensible as well as name the contexts where it will be easy for our non-technical content-editors to handle this. I'm leaning towards option a at the moment.

gnucifer’s picture

I concidered a) when implementing my new atom provider (a video service) but in the end went with the "video" type which enabled the customer to mix youtube/vimeo and "myprovider" in the same field. This was much appreciated and in hindsight any other approach would have been wrong (at least customer satisfaction-wise). I'm leaning more towards trying to establish some generic interface for all video providers, and video provider may choose to implement none, some or all of the provided settings. This is not ideal though, but the best I can think of without introducing a heckload of additional abstractions.

jcisio’s picture

Priority: Normal » Major

Promoting priority because with #2188415: Youtube provider does not import tags and recognizes correctly video dimensions getting in, lots of YouTube videos will have large dimensions that are not usable by default.

jcisio’s picture

Assigned: Unassigned » jcisio

I'm working on this.

jcisio’s picture

Status: Needs work » Fixed

  • jcisio committed ce7ea2f on 7.x-1.x
    Issue #2063785 by Raphael Apard, jcisio | discipolo: Added width/height...
jcisio’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

azinck’s picture

It seems this neglected to add support for exporting these settings via Features?

azinck’s picture

Furthermore: the problem seems to be that these dimensions are per-context rather than per-bundle-per-context like the other context settings that get stored in Features. Is there a reason this was done this way?

azinck’s picture

azinck’s picture