Part of #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']

CommentFileSizeAuthor
#23 global-user-node-2062791-23.patch6.64 KBnatemow
#22 global-user-node-2062791-21.patch6.64 KBnatemow
#20 2062791-20-global-user-node.patch7.69 KBjoelpittet
#14 2062791-14-global-user-node.patch8.09 KBjoelpittet
#12 interdiff.txt6.97 KBjoelpittet
#12 2062791-12-global-user-node.patch8.57 KBjoelpittet
#10 node-module-remove-global-user-2062791-10.patch1.9 KBm1r1k
#5 drupal8.node-module.2062791-5.patch2.3 KBsergeypavlenko
#3 drupal8.node-module.2062791-3.patch1.89 KBsergeypavlenko
#1 rename-global-user-2062791-1.patch1.78 KBjlindsey15

Comments

jlindsey15’s picture

jlindsey15 commented
Assigned: jlindsey15 » Unassigned
Status: Active » Needs review
StatusFileSize
new rename-global-user-2062791-1.patch1.78 KB

Status: Needs review » Needs work

The last submitted patch, rename-global-user-2062791-1.patch, failed testing.

sergeypavlenko’s picture

sergeypavlenko commented
Status: Needs work » Needs review
StatusFileSize
new drupal8.node-module.2062791-3.patch1.89 KB

Please make sure you have the correct comment?

Status: Needs review » Needs work

The last submitted patch, drupal8.node-module.2062791-3.patch, failed testing.

sergeypavlenko’s picture

sergeypavlenko commented
Status: Needs work » Needs review
StatusFileSize
new drupal8.node-module.2062791-5.patch2.3 KB

With patch #2076411: Remove the request scope from the current user service.

Status: Needs review » Needs work

The last submitted patch, drupal8.node-module.2062791-5.patch, failed testing.

m1r1k’s picture

m1r1k commented
Issue tags: +blocked-by-request-scope

For easy tracking

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
Issue tags: -blocked-by-request-scope

#5: drupal8.node-module.2062791-5.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +blocked-by-request-scope

The last submitted patch, drupal8.node-module.2062791-5.patch, failed testing.

m1r1k’s picture

m1r1k commented
Status: Needs work » Needs review
StatusFileSize
new node-module-remove-global-user-2062791-10.patch1.9 KB

Updated patch:

Status: Needs review » Needs work

The last submitted patch, node-module-remove-global-user-2062791-10.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
StatusFileSize
new 2062791-12-global-user-node.patch8.57 KB
new interdiff.txt6.97 KB

There seemed to be a few more missing. I hope this is right. Interdiff from #10

Status: Needs review » Needs work

The last submitted patch, 2062791-12-global-user-node.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
StatusFileSize
new 2062791-14-global-user-node.patch8.09 KB

Re-rolled, manually.

The last submitted patch, 2062791-14-global-user-node.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

14: 2062791-14-global-user-node.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 14: 2062791-14-global-user-node.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

14: 2062791-14-global-user-node.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 14: 2062791-14-global-user-node.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes
Status: Needs work » Needs review
Parent issue: » #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']
StatusFileSize
new 2062791-20-global-user-node.patch7.69 KB

Re-rolled.

Status: Needs review » Needs work

The last submitted patch, 20: 2062791-20-global-user-node.patch, failed testing.

natemow’s picture

natemow commented
Status: Needs work » Needs review
StatusFileSize
new global-user-node-2062791-21.patch6.64 KB

Re-rolled.

natemow’s picture

natemow commented
StatusFileSize
new global-user-node-2062791-23.patch6.64 KB

Re-rolled.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Nice work @natemow #23 is ready to ship.

Double checked to see if there were any global $user or $GLOBALS['user'] in the node module and it's clean.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.