First, 8.x is a very different beast and will need an entirely different patch -- it's not solved there, it's a regression in D8 that I will file. In D7, however, this is an easy documentation fix that I deem major cos if someone accidentally pretties the code here by adding $module_list = array() here then git deploy is screwed.

CommentFileSizeAuthor
#3 interdiff-2062763-1-3.txt699 bytesdarren oh
#3 drupal-update-loophole-2062763-3.patch1.19 KBdarren oh
#1 2062763_1.patch631 byteschx

Comments

chx’s picture

chx commented
StatusFileSize
new 2062763_1.patch631 bytes
chx’s picture

chx commented
Title: Document how to load git deploy during minor upgrades » Document loophole allowing loading git_deploy during minor upgrades
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Issue summary: View changes
StatusFileSize
new drupal-update-loophole-2062763-3.patch1.19 KB
new interdiff-2062763-1-3.txt699 bytes

It is also necessary to load the modules in $module_list. Otherwise, hacks are required such as adding an empty bootstrap hook to the module or loading the module in settings.php.

drzraf’s picture

drzraf commented

settings $GLOBALS['module_list'] in settings.php does not seem to work (anymore ?), tested with Drupal 7.35

the workaround still does work
(drush just didn't modified the info file because it aborted with an error because it failed to add the module as a git submodule)
sorry for the noise

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Title: Document loophole allowing loading git_deploy during minor upgrades » Fix update.php missing version info from git_deploy

I've created a pull request to get the same workaround supported by drush.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Title: Fix update.php missing version info from git_deploy » Fix update.php missing version info from Git Deploy
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Needs review » Fixed

Found a fix that does not require a core patch.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Project: Drupal core » Git Deploy
Version: 7.x-dev » 7.x-2.x-dev
Component: database update system » Code

  • Darren Oh committed c58b448 on 7.x-1.x 
    Issue #2062763 by chx and Darren Oh: Fix update.php missing version info...
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

New pull request for Drush: https://github.com/drush-ops/drush/pull/4397

  • Darren Oh committed 10f755a on 7.x-2.x 
    Issue #2062763 by Darren Oh: Add support for drush updatedb command

  • Darren Oh committed 739d0dd on 7.x-1.x 
    Issue #2062763 by Darren Oh: Add support for drush updatedb command

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.