Part of meta-issue #2052421: [META] Rename Views properties to core standards

CommentFileSizeAuthor
#4 20620153-rename-views-properties-4.patch5 KBmichaelhiiva
#1 rename-views-properties.patch567 byteschertzog

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Assigned: danylevskyi » Unassigned
Status: Active » Needs review
StatusFileSize
new rename-views-properties.patch567 bytes

Patch attached.

Status: Needs review » Needs work

The last submitted patch, rename-views-properties.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented

This does not work, because once you rename a variable you have to rename all usages of all base and subclasses too.

michaelhiiva’s picture

michaelhiiva commented
Status: Needs work » Needs review
StatusFileSize
new 20620153-rename-views-properties-4.patch5 KB

New Patch.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Good work!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 8dd8210 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.