Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

CommentFileSizeAuthor
#6 2062031-replace-user_access-calls-6.patch684 bytesmichaelhiiva
#6 interdiff-2062031-1-6.txt832 bytesmichaelhiiva
#1 drupal-tour_replace_user_access-2062031.patch782 bytesinternetdevels

Comments

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new drupal-tour_replace_user_access-2062031.patch782 bytes

Here is the patch.

Status: Needs review » Needs work
Issue tags: -CodeSprintCIS

The last submitted patch, drupal-tour_replace_user_access-2062031.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review

#1: drupal-tour_replace_user_access-2062031.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +CodeSprintCIS

The last submitted patch, drupal-tour_replace_user_access-2062031.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Component: user system » tour.module 
+++ b/core/modules/tour/tour.module
@@ -73,7 +73,8 @@ function tour_library_info() {
+  $account = Drupal::request()->attributes->get('_account');

@@ -107,7 +108,8 @@ function tour_toolbar() {
+  $account = Drupal::request()->attributes->get('_account');

Use Drupal::currentUser() service https://drupal.org/node/2032447

michaelhiiva’s picture

michaelhiiva commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2062031-1-6.txt832 bytes
new 2062031-replace-user_access-calls-6.patch684 bytes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Nice!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.