Files: 
CommentFileSizeAuthor
#15 overlay-remove-global-user-from-overlay-module-2061967-15.patch1.05 KBm1r1k
PASSED: [[SimpleTest]]: [MySQL] 58,945 pass(es).
[ View ]
#14 drupal8.overlay-module.2061967-14.patch1.05 KBsergeypavlenko
PASSED: [[SimpleTest]]: [MySQL] 58,138 pass(es).
[ View ]
#3 2061967-2.patch1.08 KBMaxis
FAILED: [[SimpleTest]]: [MySQL] 57,908 pass(es), 39 fail(s), and 3 exception(s).
[ View ]
#1 2061967-1.patch1.08 KBMaxis
FAILED: [[SimpleTest]]: [MySQL] 57,621 pass(es), 39 fail(s), and 3 exception(s).
[ View ]

Comments

Maxis’s picture

StatusFileSize
new1.08 KB
FAILED: [[SimpleTest]]: [MySQL] 57,621 pass(es), 39 fail(s), and 3 exception(s).
[ View ]
Spleshka’s picture

Status:Active» Reviewed & tested by the community

I see to reasons why we can't make it RTBC. Thanks!

Maxis’s picture

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new1.08 KB
FAILED: [[SimpleTest]]: [MySQL] 57,908 pass(es), 39 fail(s), and 3 exception(s).
[ View ]
Spleshka’s picture

Any difference between patches?

Maxis’s picture

no differenece, but i forgot set status to needs review in my first comment..

Maxis’s picture

Will bot put himself patch on the test?

Spleshka’s picture

Yep, he already did it. Just wait for the results. But patch seems to be obvious.

Maxis’s picture

thanks$)

Maxis’s picture

i did simple test, it returned 34 passes, 0 fails, 0 exceptions, and 9 debug messages

Spleshka’s picture

Wait for the test results. Patch won't get commited until it pass a test bot.

Status:Needs review» Needs work
Issue tags:-CodeSprintCIS

The last submitted patch, 2061967-2.patch, failed testing.

Spleshka’s picture

Status:Needs work» Needs review

#3: 2061967-2.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+CodeSprintCIS

The last submitted patch, 2061967-2.patch, failed testing.

sergeypavlenko’s picture

Status:Needs work» Needs review
StatusFileSize
new1.05 KB
PASSED: [[SimpleTest]]: [MySQL] 58,138 pass(es).
[ View ]
m1r1k’s picture

StatusFileSize
new1.05 KB
PASSED: [[SimpleTest]]: [MySQL] 58,945 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:-CodeSprintCIS

The last submitted patch, overlay-remove-global-user-from-overlay-module-2061967-15.patch, failed testing.

m1r1k’s picture

Status:Needs work» Needs review
Issue tags:+CodeSprintCIS
joelpittet’s picture

Assigned:Maxis» Unassigned
Status:Needs review» Reviewed & tested by the community
Issue tags:+Quick fix

Looks like #16 still applies, passes tests and does what the summary is requesting.

Thank you @m1r1kand, @sergeypavlenko, and @Maxis

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

webchick’s picture

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.