Part of #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']
replace

function update_access_allowed() {
  global $user;
CommentFileSizeAuthor
#9 2061949-9-global-user-depricated-update.patch478 bytesjoelpittet
#4 updatephp-remove-global-user-from-update-php-2061949-4.patch897 bytesm1r1k
#2 updatephp-remove-global-user-from-update-php-2061949-2.patch477 bytesm1r1k
#1 2061949-1.patch728 bytesGarbar

Comments

Garbar’s picture

Garbar commented
Status: Active » Needs review
StatusFileSize
new 2061949-1.patch728 bytes

Fix. Needs review.

m1r1k’s picture

m1r1k commented
StatusFileSize
new updatephp-remove-global-user-from-update-php-2061949-2.patch477 bytes

Rerolling after #2062151: Create a current user service to ensure that current account is always available:

Status: Needs review » Needs work

The last submitted patch, updatephp-remove-global-user-from-update-php-2061949-2.patch, failed testing.

m1r1k’s picture

m1r1k commented
StatusFileSize
new updatephp-remove-global-user-from-update-php-2061949-4.patch897 bytes

Add this patch #2076411: Remove the request scope from the current user service:

m1r1k’s picture

m1r1k commented
Assigned: Garbar » m1r1k
Status: Needs work » Needs review

Pushed to retesting

m1r1k’s picture

m1r1k commented
Status: Needs review » Postponed
Issue tags: +blocked-by-request-scope
catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

#2: updatephp-remove-global-user-from-update-php-2061949-2.patch queued for re-testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Assigned: m1r1k » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2061949-9-global-user-depricated-update.patch478 bytes

I'm RTBCing #2 the patch attached is the same just with a \ for the namespace. @see #2053489: Standardize on \Drupal throughout core

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: Remove calls to deprecated global $user in update module » Remove calls to deprecated global $user in update.php
Issue tags: -CodeSprintCIS, -blocked-by-request-scope

retitling because the issue summary is meant for the update.php not the update module.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a18f9c6 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.