Part of #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']
replace

function update_access_allowed() {
  global $user;
Files: 
CommentFileSizeAuthor
#9 2061949-9-global-user-depricated-update.patch478 bytesjoelpittet
PASSED: [[SimpleTest]]: [MySQL] 59,092 pass(es). View
#4 updatephp-remove-global-user-from-update-php-2061949-4.patch897 bytesm1r1k
PASSED: [[SimpleTest]]: [MySQL] 58,398 pass(es). View
#2 updatephp-remove-global-user-from-update-php-2061949-2.patch477 bytesm1r1k
PASSED: [[SimpleTest]]: [MySQL] 59,061 pass(es). View
#1 2061949-1.patch728 bytesGarbar
PASSED: [[SimpleTest]]: [MySQL] 57,965 pass(es). View

Comments

Garbar’s picture

Status: Active » Needs review
FileSize
728 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,965 pass(es). View

Fix. Needs review.

m1r1k’s picture

Status: Needs review » Needs work

The last submitted patch, updatephp-remove-global-user-from-update-php-2061949-2.patch, failed testing.

m1r1k’s picture

FileSize
897 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,398 pass(es). View
m1r1k’s picture

Assigned: Garbar » m1r1k
Status: Needs work » Needs review

Pushed to retesting

m1r1k’s picture

Status: Needs review » Postponed
Issue tags: +blocked-by-request-scope
catch’s picture

Status: Postponed » Needs review
joelpittet’s picture

joelpittet’s picture

Assigned: m1r1k » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
478 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,092 pass(es). View

I'm RTBCing #2 the patch attached is the same just with a \ for the namespace. @see #2053489: Standardize on \Drupal throughout core

joelpittet’s picture

Title: Remove calls to deprecated global $user in update module » Remove calls to deprecated global $user in update.php
Issue tags: -CodeSprintCIS, -blocked-by-request-scope

retitling because the issue summary is meant for the update.php not the update module.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed a18f9c6 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.