Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
content_translation.module
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
8 Aug 2013 at 11:53 UTC
Updated:
29 Jul 2014 at 22:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
gábor hojtsyComment #2
thamasWokin' on it :)
Comment #3
thamasHere is the patch which adds the missing padding and removes some unneeded lines. It (hopefully) also fixes some inconsistencines in drupal.base.css I found during working on the original issue.
Before:
After:
(Sorry for sending it so much later I assigned it to myself but DrupalCon catched me… ;))
Comment #4
rteijeiro commentedThis file doesn't exists, so patch doesn't apply :(
Comment #5
thamasOhh, it was removed two days later: https://drupal.org/node/1839318#comment-7912709
I'll reroll the patch… Thanks for the review!
Comment #6
thamasRerrolled without the removed drupal.base.css
Comment #7
thamasComment #8
rteijeiro commentedPatch applies well and code seems right. Well done!
Comment #9
thamasThanks for the review! :)
Comment #10
tstoecklerSorry if this is obvious, but:
Any reason to add this additional padding? I don't see the equivalent being added in ltr-mode.
Comment #11
gábor hojtsyI think that would be the standard table cell padding that is overridden in the LTR version, so needs to set back again? @thamas, can you confirm?
Comment #12
thamasWe are overriding the 3em and 5em left padding which are defined earlier in LTR settings.
Comment #13
gábor hojtsyTag on sprint for easier tracking.
Comment #14
plachComment #15
catchCommitted/pushed to 8.x, thanks!
Comment #16
gábor hojtsyYay! Thanks!
Maybe you noticed the random distracting labels right near the checkboxes on the screenshots in #3, those are *not supposed to be there*. Simple RTBC issue at #2112303: Random extra text around translatability configuration is confusing.