Problem/Motivation
The content translation form now includes duplicate labels for some of the items listed. But not all of them:
Entity types are lowercase, so even looks uglier. However, none of these extra labels are needed at all. The markup / table render contains all sufficient labels in the next column of the table and that is properly cross references with <label for=""></label>
tags. Also those labels are accessible including the full hierarchy of items like so:
<label for="edit-settings-node-article-columns-field-image-file"><span class="visually-hidden">Article</span> <span class="visually-hidden">Image</span> File</label>
Proposed resolution
So the "randomly" displayed labels right next to checkboxes are absolutely superfluous and should go away as they were before. The original version of the form did not include these and the appearance of them is a regression. Resulting table:
Remaining tasks
Review, commit :)
User interface changes
Clean translation configuration table.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
ContentLabelsAfter.png | 71.01 KB | Gábor Hojtsy | |
ExtraContentLabels.png | 114.82 KB | Gábor Hojtsy | |
extra-random-labels.patch | 1.15 KB | Gábor Hojtsy | |
Comments
Comment #1
Gábor HojtsyComment #2
Gábor HojtsyThis has been introduced in #2074509: Add missing #title property to ensure form accessibility.
Comment #3
Gábor HojtsyAlso an accessibility problem that the extra labels lack crucial information about the structure of the form that are otherwise included with the labels later on. With having two labels marked up for the same checkboxes, it is up to browsers to pick and picking the extra ones reduces accessibility a great deal. :/
Comment #4
YesCT CreditAttribution: YesCT commentedI tried this out on simplytest.me
works great.
Comment #5
vijaycs85+1 for the RTBC.
Comment #6
Gábor HojtsyComment #7
vijaycs85extra-random-labels.patch queued for re-testing.
Comment #8
webchickUhm, wow, that's pretty awful! Glad the fix is so easy. :)
Committed and pushed to 8.x. Thanks!
Comment #9
Gábor HojtsyYay, thanks!
Comment #11
apadernoComment #12
mgiffordFixing the tag.