Properties such as 'errors' and 'module' are getting exported. They should not be.

CommentFileSizeAuthor
#3 flags_export_after_patch.txt783 bytesshabana.navas
#3 flags_export_before_patch.txt816 bytesshabana.navas
#2 2059967.flag_.flag-properties-dont-export.patch1.42 KBjoachim

Comments

joachim’s picture

joachim commented

'module' is intentionally exported:

      // Even though Flag adds the module name itself later, we add the module
      // name here for reference by other modules (such as Features).
      $new_flag['module'] = $module;
joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 2059967.flag_.flag-properties-dont-export.patch1.42 KB

Figured this bit of the code could use a little clean-up at the same time.

shabana.navas’s picture

shabana.navas commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new flags_export_before_patch.txt816 bytes
new flags_export_after_patch.txt783 bytes

I have tested this now and I can confirm it works. I have attached the before and after versions of the export. The original exported the 'errors' array. However, after the patch was applied, the 'errors' array, as expected, was not exported.

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review!

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.