PHP notice when #attributes is not set with #theme_wrappers 'container'

Nice fix. I think we should backport it.

tagging for backport

I've confirmed the new Drupal\system\Tests\Common\RenderElementTypesTest fails when the patch is not applied to theme.inc

+++ b/core/modules/system/lib/Drupal/system/Tests/Common/RenderElementTypesTest.phpundefined
@@ -0,0 +1,116 @@
+ * Definition of Drupal\system\Tests\Common\RenderElementTypesTest.

Should be "Contains..."

+++ b/core/modules/system/lib/Drupal/system/Tests/Common/RenderElementTypesTest.phpundefined
@@ -0,0 +1,116 @@
+        'name' => "#type 'container' with a class HMTL attribute",

HTML :)

Committed 5d3b946 and pushed to 8.x. Thanks!

Probably not worth reopening for 8.x but should be "Contains \Drupal…" for next time.

Moving to 7.x for the backport.

I got the core code, since it is only 2 lines, but I'm a little confused on how to back port the test case.

I see you removed a file and created a new one for D8, should I be looking to do the same in D7? It looks like it is set up a little different.

hmmm, how different is the setup? ideally you'd want the changes to be 1:1, but if that's not possible we should have a quick discussion about why we can't do it then use common sense to finish this up.

I just wasn't looking in the right spot. Looks like it is in theme.test instead of common.test in D7. I'll spend some time working on it.

Ok, let's give this a shot.

I guess I should slow down before submitting the patch. Last one was only the test, didn't include the actual fix. This one should do.

Really sorry about spamming the log. I'll get the hang of this.

Ok, this one runs locally. I assume using a #type => html_tag is equivalent to calling theme_html_tag directly, since that is what is in the original patch.

D7 doesn't appear to support #markup so I used a child array instead for the container tests.

Last patch somehow had a spacing issue that didn't show up in my IDE. Is there a way to run dreditor over a patch before posting?

@thedavidmeister - any concerns about the latest patch? Does it still need to be cleaned up?

It still applies nicely and would be good to avoid these notice's if we can.

#22 looks ok to me.

Note that the D7 test has one fewer assertions than in D8. As mentioned in #21, D7 doesn't support #markup in container render arrays.

Also, note that the D8 patch changed the focus of the test class, from saying that it tests HTML tags to testing element render arrays. The D7 patch does the same thing. A lot of the code gets moved around and formatted differently to match D8. I checked it and I think it's all good.

Yet another random test failure.

I agree with RTBC for that.

Committed to 7.x - thanks!

Nice cleanup work on those tests, too.