It would be good to move the City JS and CSS (which their API provides) out of the module and have it as a library (i.e. in sites/all/libraries).

The advantage of this is that it means you won't need to maintain third party code which probably doesn't conform to the Drupal standard.

Comments

guy_schneerson’s picture

guy_schneerson commented

I have noticed a few contrib modules have a dependency on the libraries module.

funex’s picture

funex commented

Thanks Guy, I'll take a look. Can you tell me which ones?

guy_schneerson’s picture

guy_schneerson commented

checkout https://drupal.org/project/chosen a jQuery plugin implementation.