Because the style plugin system has gone through several iterations, it had some leftovers due to temporary backwards compatibility, inconsistent commenting, and sometimes even small bugs. This patch tries to fix that.

- added "Panels hooks", "Panels style plugin callbacks" and "Themeing callbacks" sections
- wrapped comments properly
- consistent ternary operators
- in every style, you were using $display->content[$pid], while $pid was not defined
- removed the panels implementations entries in all implementatinos of hook_panels_style_info()
- standardized on "Render panel callback." for render panel callbacks
- standardized on "Settings form callback." as the comment for settings form callbacks
- documented the additional themeing functions of the rounded corners style
- the dnd style was no longer used at all, hence this file can be deleted (all styling for this is included in display_edit.inc). Or should I alter the Panels module to use this style again?

CommentFileSizeAuthor
#1 consistent_panels_style_plugins.patch9.6 KBwim leers
consistent_panels_style_plugins.patch9.54 KBwim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new consistent_panels_style_plugins.patch9.6 KB

Reroll from Panels module root directory.

merlinofchaos’s picture

merlinofchaos commented

dnd.inc was never used -- I'd initially wanted to have the drag & drop as a style, but I've decided to go a different direction, because I don't actually want teh content in there anymore. There are issues caused by putting the content in there on the admin page.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Oh and I committed the patch and removed dnd.inc

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.