In _responsive.css shouldn't the changing $zen-column-count variables be inside the associated media queries?

They were moved outside the media queries, in commit "Remove double blank lines in Sass files"

on 11/15/12 where all other files just had blank lines removed, _layout-responsive.scss only moved $zen-column-count.

The latest examples of zen-grids on github also have the variable inside the media queries.

I'm curious why, but if this was not intentional, this patch moves the media query specific $zen-column-count variables back inside the media queries.

CommentFileSizeAuthor
column-count-inside-mq.patch1009 bytesechoz

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Assigned: Unassigned » johnalbin

The comment should be before the media query, but you are right, the variable should be inside. Moving now.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: move $zen-column-count back inside media queries » Move $zen-column-count back inside media queries
Assigned: johnalbin » Unassigned
Status: Needs review » Fixed

Fixed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.