Move search block form to new drupal 8 standard

I think test coverage for this is provided in core/modules/search/lib/Drupal/search/Tests/SearchBlockTest.php

+++ b/core/modules/search/lib/Drupal/search/Form/SearchBlockForm.phpundefined
@@ -0,0 +1,78 @@
+   * Implements \Drupal\Core\Form\FormInterface::getFormID().

these can be inheritdoc now #1906474: [policy adopted] Stop documenting methods with "Overrides …"

+++ b/core/modules/search/lib/Drupal/search/Form/SearchBlockForm.phpundefined
@@ -0,0 +1,78 @@
+ * Search form for the Search Block.

classes get third person verbs also. https://drupal.org/coding-standards/docs#classes

and some newlines: https://drupal.org/node/608152#indenting

and took out some trailing white space.

I'll test it next and take a look at the actual conversion.

I compared the

878 $ diff !$ ../patch-garbage/search-interface-buildform.php
diff ../patch-garbage/search-interface-search_box.php ../patch-garbage/search-interface-buildform.php
1,2c1,2
< function search_box($form, &$form_state, $form_id) {
<   $form[$form_id] = array(
---
> public function buildForm(array $form, array &$form_state) {
>   $form['search_block_form'] = array(
12d11
<   $form['#submit'][] = 'search_box_form_submit';

[~/foo/d8]
07:49 PM [YesCT]  (drush-iq-move-search-block-form-to-new-drupal-2052325-#1) 
881 $ diff ../patch-garbage/search-interface-search_box_form_submit.php ../patch-garbage/search-interface-submitForm.php
1c1
< function search_box_form_submit($form, &$form_state) {
---
> public function submitForm(array &$form, array &$form_state) {

and the copy is very straight forward. so I think it is ok.

while looking I noticed $_GET

----

+++ b/core/modules/search/lib/Drupal/search/Form/SearchBlockForm.phpundefined
@@ -0,0 +1,81 @@
+    if (isset($_GET['destination'])) {

I think these $_GET should be replaced with getting from the request.

ending up with something like $this->request->query->get('...

+++ b/core/modules/search/lib/Drupal/search/Form/SearchBlockForm.phpundefined
@@ -0,0 +1,92 @@
+    if (isset($this->request) && $this->request->query->has('destination')) {

I was stumbling upon that isset. How can request not be set here. We figured it out that the request object is actually not injected from drupal_get_form. For form pages you have the controller resolver which cares about the injection but here we need to inject the request object into the SearchBlock plugin and then put it into the form arguments via drupal_get_form

+++ b/core/modules/search/lib/Drupal/search/Plugin/Block/SearchBlock.phpundefined
@@ -33,7 +34,7 @@ public function access() {
-    return array(drupal_get_form('search_block_form'));
+    return array(drupal_get_form(new SearchBlockForm()));

This should not be an array, as drupal_get_form is already a render array.

+++ b/core/modules/search/search.moduleundefined
@@ -1309,14 +1252,3 @@ function search_simplify_excerpt_match($key, $text, $offset, $boundary, $langcod
-/**
- * Implements hook_forms().
- */
-function search_forms() {
-  $forms['search_block_form']= array(
-    'callback' => 'search_box',
-    'callback arguments' => array('search_block_form'),
-  );
-  return $forms;

Back in the days there has been two implementations ('search_block_form', 'search_theme_form'), so it is safe to remove now.

Wow, this is an awesome patch. You removed search_box()!!! Nice...

Also, quite impressive that there's so little to complain after only ~10 comments on your first patch. Way to go!

I just found some small nitpicks, and then this should be ready to go.

+++ b/core/modules/search/lib/Drupal/search/Form/SearchBlockForm.php
@@ -0,0 +1,92 @@
+use Drupal\Core\Controller\ControllerInterface;
...
+use Symfony\Component\DependencyInjection\ContainerInterface;

I might be missing something, but I think these are not actually used in this file.

+++ b/core/modules/search/lib/Drupal/search/Form/SearchBlockForm.php
@@ -0,0 +1,92 @@
+ * Builds the search form for the Search Block.

"Search" and "Block" should be lowercase.

That is ready to fly now.

Committed b397954 and pushed to 8.x. Thanks!