panopoly-admin.css harmonizes the content admin experience. Themes like Kalatheme and Radix leverage bootstrap, however, to provide consistent UI elements, so they disable panopoly-admin.css.

This has the unfortunate consequence of killing the panopoly icons in the navbar. Rather than redeclaring in these themes css that should live here, can we split the navbar css into its own file?

see: #2049867: Panopoly and Apps icons do not appear in the navbar

CommentFileSizeAuthor
#11 decouple_navbar_styling-2051621-11.patch6.7 KBmglaman
#7 decouple_navbar_styling-2051621-7.patch2.11 KBmglaman

Comments

andrew_mallis’s picture

andrew_mallis commented

Will you accept a patch?

populist’s picture

populist commented

That would be acceptable and thanks for asking. You are so considerate you must be a Canadian.

pirog’s picture

pirog commented

That is not how we would have done it in Mother Russia

andrew_mallis’s picture

andrew_mallis commented

quick note here that:

  1. the images should be referenced with relative paths, to squash #2074567: Hard coded icon ...
  2. we should probably just load the navbar css if the module's on
liza’s picture

liza commented

is there a patch forthcoming?

lsolesen’s picture

lsolesen commented

Would be cool if @Andrew Mallis could create the patch :)

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new decouple_navbar_styling-2051621-7.patch2.11 KB

Here is patch to split up navbar tray customizations into panopoly-admin-navbar. +1 for this because I have my own contrib module which themes the navbar (Navbar Awesome) and this would conflict!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Reviewed & tested by the community

This may have an impact on Panopoly themes that are already doing something special to work around this. Can some open issues in Radix and Kalatheme explaining that updates may be necessary and link back here?

Otherwise, the patch looks good to me!

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Radix: #2324607: Decoupled Navbar styling in Panopoly Admin
Kalatheme: https://github.com/drupalprojects/kalatheme/issues/136

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Needs work

Thanks, Matt! I was about to commit this, but it looks like some Navbar styling was missed. There's the icons at the bottom of the panopoly-admin.css too. Basically, everything under this comment should move:

/**
 * Navbar Styling
 */
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new decouple_navbar_styling-2051621-11.patch6.7 KB

Updated patch with everything moved over.

  • dsnopek committed 8b4ce09 on 7.x-1.x 
    Update Panopoly Admin for #2051621 by mglaman | Andrew_Mallis: Added...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Committed!

andrew_mallis’s picture

andrew_mallis commented

yay!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.