Make Panels layout from Panopoly Theme work with Radix

So, this is making Panopoly's layouts work with Radix. Why not instead make Panopoly use Radix Layouts? Certainly more people than Panopoly users will want to use these layouts?

I've got some ideas about this, as far as the radix panopoly distribution that Arshad has going (can't find it at the moment, so I'll report here).

First of all, Panopoly is distributed with a different theme and its own layouts, unless panopoly is actually switching to radix?! I might actually live much more under a rock than I realize if this is the case.

I've recently researched some approaches to programmatically set allowed panels layouts to *only* radix ones using the panels 3.x allowed layouts constructor function. The other thing would be to automatically swap all panelizer display layouts and PM panel pages to use their radix equivalents, which I may just do with sql (can't wait til D8! Config in YAML ftw!). I actually don't need this right away, but if anyone does, let me know and I'd be glad to put more time into it. It'd be good to, in panopolyesque fashion, make this available as a setting on a 'Panopoly Radix' setting page.

Patch updated to apply cleanly against latest code.

Adding to the sprint so that hopefully we can address this by 1.0.

It should probably not be too difficult to switch base theme - if Panopoly should be adopted by the masses :)

FYI I've made patches to the bootstrap theme that make it work quite flawlessly with panopoly using bootstrap 3. I've also ported most of the panopoly layouts to work in bootstrap 3, and begun on a series of style plugins. IMHO the radix project should be folded into bootstrap.

@rerooting It would make a lot of sense. Maybe you and @arshadcn could make a proposal. I know he will be working on Radix soon.

patch #5 verified with panopoly layout, regions respond correctly for narrow width screen

It will be very useful to have panopoly layouts work with radix. If you have used panopoly layouts and switch to radix eveything is borked.

One of the alternatives to this patch, which we discussed a bit on IRC today, is to have Panopoly depend on Radix Layouts. I'm pretty fond on this idea! Although, we could go with this patch in the interim (since it's the easiest/quickest way to get there) and switch to depending on Radix Layouts later without any extra work.

let's use this patch for 1.2 and change to the dependency in 1.3.

As long as you do not force developers into using Radix and Bootstrap for their theming of their sites.

@lsolesen: Arshad said in IRC today that the Radix Layouts are completely theme independent, ie. it includes the grid CSS that it depends on. Anyway, I agree - if the Radix Layouts turned out not to be reusable outside of Radix and Panopoly, we'd have to make sure they got patched so that was the case. :-)

As I said in comment #2: it just seems weird to have Panopoly's layouts be part of Panopoly Theme. I could imagine some users wanting to have the layouts, but not wanting all of Panopoly Theme. Luckily for us, Radix Layouts already exists and is basically Panopoly's layouts in a seperate module!

@caschbre: I agree! I've committed this patch:

http://drupalcode.org/project/panopoly_theme.git/commitdiff/d409deb826c4...

And created this follow-up issue:

#2191069: Have Panopoly Theme depend on Radix Layouts (rather than providing it's own)

Thanks to everyone who tested this patch and engaged in this discussion!

We're one step closer to:

#1987386: Include Radix theme in Panopoly

:-)

I recently updated modules and the classes have changed in the most recent release. They are incorrect. The 'moscone-footer' classes have changed to 'moscone-header'.

Priority to Major, because as far as this module goes, this is just about as bad as it can get: Site designs can be broken on upgrade.

http://drupalcode.org/project/panopoly_theme.git/blobdiff/a2424825f4514d...

-  <div class="moscone-container moscone-footer clearfix panel-panel">
-    <div class="moscone-container-inner moscone-footer-inner panel-panel-inner">
+  <div class="moscone-container moscone-header clearfix panel-panel row-fluid">
+    <div class="moscone-container-inner moscone-header-inner panel-panel-inner span12">

Problem occurs in moscone-flipped.tpl.php and moscone.tpl.php. Maybe elsewhere.

Try this patch.

@eosrei: Thanks for finding this bug, and @lsolesen: thanks for making a fix so quickly!

However, this needs to be a new issue: #2228095: Classes wrong on "moscone" layouts

I'm going to try to commit this sometime this afternoon.

This also got me thinking that it'd be really cool to have Behat tests for the layouts: #2228099: Write Behat tests for layouts

Then we'd never break the layouts ever again. :-)

Thanks for fixing it quickly. I was in the middle of updating that project at the time and didn't have a moment to write the patch.

RE New issue: I wasn't sure it belonged in a new issue, I'll put such things in a new issue in the future.