We found that when using the same field across different taxonomy fields, the module doesn't take the bundle into consideration for machine name uniqueness. This may be the intended behaviour, however in our case we patched the validation function to also check on the bundle type.

Now our taxonomy vocabs called "Story type" and "Callout type" can now have a shared field machine name on a term called "analysis"- and both can have the same machine name.

This may cause limitations in that it will require you to explicitly refer to the bundle and cannot rely on uniqueness on entity type alone.

Patch attached.

CommentFileSizeAuthor
machine_name--unique_across_entity_bundle_combo.patch990 bytesbarry_fisher

Comments

danrod’s picture

danrod
Location Ottawa
commented
Version: 7.x-1.0 » 7.x-1.x-dev
Issue summary: View changes
danrod’s picture

danrod
Location Ottawa
commented

I tested this on an old D7 instance and works as expected, even though support for D7 ended a long time ago, there is still some sites that run the Drupal 7 version of this project, so I'll commit this to the 7.x-1.x branch, hoping that someone would benefit of this addition.

danrod’s picture

danrod
Location Ottawa
commented
Status: Needs review » Reviewed & tested by the community
danrod’s picture

danrod
Location Ottawa
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.