Unable to activate content translation in the content type edit form. [#2046541]

When saving the content type for content translation the submit callback that saves the config is not executed. This is due to the fact that the primary submit function is attached to the button and not to the form array.

Edit_Article_content_type___d8dev.local_.png

Comment	File	Size	Author
#3	drupal-unable-activate-content-translation-content-type-form-2046541-3.patch	2.06 KB	e0ipso
#1	drupal-unable-activate-content-translation-content-type-form-2046541-1-test-only.patch	1.38 KB	e0ipso
#1	drupal-unable-activate-content-translation-content-type-form-2046541-1.patch	2.06 KB	e0ipso
	Edit_Article_content_type___d8dev.local_.png	107.87 KB	e0ipso

Comments

Comment #1

e0ipso

Catalan

Can Picafort

commented 20 July 2013 at 15:24

Status:	Active	» Needs review
Issue tags:	-Needs tests

Status	File	Size
new	drupal-unable-activate-content-translation-content-type-form-2046541-1.patch	2.06 KB
new	drupal-unable-activate-content-translation-content-type-form-2046541-1-test-only.patch	1.38 KB

First attempt. Co-author: @plopesc

Comment #2

gábor hojtsy

he/him

Hungarian

Hungary

commented 23 July 2013 at 12:01

Status:	Needs review	» Needs work
Issue tags:		+sprint, +language-content

Wow, hum! Good find. Thanks for the fix. Also good test coverage. Only some English language picks:

+++ b/core/modules/content_translation/lib/Drupal/content_translation/Tests/ContentTranslationSettingsTest.phpundefined
@@ -101,6 +101,18 @@ function testSettingsUI() {
+    // Verify that the translation may be enabled for the article content type.

Remove "the" before "translation" to be better English :)

+++ b/core/modules/content_translation/lib/Drupal/content_translation/Tests/ContentTranslationSettingsTest.phpundefined
@@ -101,6 +101,18 @@ function testSettingsUI() {
+    // Make sure the checkbox is available and disabled by default.

"disabled" => "not checked" (disabled checkboxes cannot be checked :)